Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring]: Move the StmtGraph.buildTraps() API into the JimplePrinter #1119

Closed
stschott opened this issue Oct 21, 2024 · 0 comments · Fixed by #1125
Closed

[Refactoring]: Move the StmtGraph.buildTraps() API into the JimplePrinter #1119

stschott opened this issue Oct 21, 2024 · 0 comments · Fixed by #1125
Assignees
Labels
improvement improve in readability, structure or performance

Comments

@stschott
Copy link
Collaborator

stschott commented Oct 21, 2024

Missing Feature

The StmtGraph.buildTraps() API should only be used for the serialization for Jimple and should therefore be moved to the JimplePrinter. This also requires the adjustment of some code depending on this API (e.g. Body.getTraps() and uses in test cases).

Additionally, to avoid the "invalid StmtGraph because a trap's end stmt was not visited" exception when printing traps, add a nop statement in cases where a trap's end stmt is missing.

@stschott stschott added the improvement improve in readability, structure or performance label Oct 21, 2024
@sahilagichani14 sahilagichani14 self-assigned this Oct 21, 2024
@sahilagichani14 sahilagichani14 linked a pull request Nov 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement improve in readability, structure or performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants