-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add failing test case #1125
Merged
sahilagichani14
merged 19 commits into
develop
from
1119-refactoring-move-the-stmtgraphbuildtraps-api-into-the-jimpleprinter
Jan 8, 2025
Merged
add failing test case #1125
sahilagichani14
merged 19 commits into
develop
from
1119-refactoring-move-the-stmtgraphbuildtraps-api-into-the-jimpleprinter
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…graphbuildtraps-api-into-the-jimpleprinter
…graphbuildtraps-api-into-the-jimpleprinter
…ses, buildtraps to LabeledStmtPrinter
…graphbuildtraps-api-into-the-jimpleprinter
…graphbuildtraps-api-into-the-jimpleprinter
swissiety
requested changes
Jan 6, 2025
sootup.core/src/main/java/sootup/core/util/printer/BlockGraphIteratorAndTrapAggregator.java
Outdated
Show resolved
Hide resolved
sootup.core/src/main/java/sootup/core/util/printer/LabeledStmtPrinter.java
Outdated
Show resolved
Hide resolved
sootup.core/src/main/java/sootup/core/util/printer/LabeledStmtPrinter.java
Outdated
Show resolved
Hide resolved
…graphbuildtraps-api-into-the-jimpleprinter
…graphbuildtraps-api-into-the-jimpleprinter
swissiety
approved these changes
Jan 8, 2025
Comment on lines
69
to
70
public final JimplePrinter jimplePrinter = new JimplePrinter(); | ||
public final BriefStmtPrinter briefStmtPrinter = new BriefStmtPrinter(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please dont
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed fields and used them directly
sahilagichani14
deleted the
1119-refactoring-move-the-stmtgraphbuildtraps-api-into-the-jimpleprinter
branch
January 8, 2025 15:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.