-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(entity-archival): add package for entity level archival #2137
base: master
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
private options: ArchivalComponentOptions = DEFAULT_ARCHIVAL_OPTIONS, | ||
) { | ||
this.providers = {}; | ||
this.application.component(CoreComponent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have this dependency ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we move this to soft-delete this will no longer be required as I needed this to check if the repo is using DefaultCRUD by loopback or DefaultSoftDelete by ARC since the 'delete' methods are different for both
packages/archival/README.md
Outdated
|
||
## Overview | ||
|
||
`@sourceloop/entity-archival` package is a powerful LoopBack 4 extension designed to seamlessly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after reading this, I feel this should be part of soft delete package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will move once the changes are approved as there are comments to be resolved
packages/archival/src/providers/process-import-data.provider.ts
Outdated
Show resolved
Hide resolved
* return the json data to user | ||
*/ | ||
|
||
async import(jobId: string) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Entire flow for retrieval should be in this service file
data.push(...fileContent); | ||
} | ||
|
||
const dsName = 'db'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactor this code. ensure connection is closed gracefully
53f880a
to
09db749
Compare
11a5dc8
to
0a50c23
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
gh-1778
Description
Added a new package for entity level archival
Fixes #1778
Type of change
Please delete options that are not relevant.
Checklist: