Ensure we don't use newer toml-rb which requires a compiler #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramereth
added
the
Release: Minor
The toml-rb 3.0.0 gem adds an explicit dependency on racc ~> 1.7 which requires a compiler. For now don't pull in newer gem as it complicates the logic of the various libraries. This resolves #455 Signed-off-by: Lance Albertson <[email protected]>
Signed-off-by: Lance Albertson <[email protected]>
Signed-off-by: Lance Albertson <[email protected]>
Signed-off-by: Lance Albertson <[email protected]>
Signed-off-by: Lance Albertson <[email protected]>
Signed-off-by: Lance Albertson <[email protected]>
ramereth
changed the title
AmazonLinux 2023 isn't quite ready or seems to have an issue with the dokken container. Signed-off-by: Lance Albertson <[email protected]>
|
@bmhughes I couldn't figure out how to get the newer gem to work with getting the compiler installed before the libraries load. For now this seems like the best short term solution. Let me know if you have a better idea. |
|
I've gotten this to work for postgresql so I'd think that pattern should work. This will work for the meantime though for sure. |
bmhughes
approved these changes
Mar 10, 2024
|
Released as: 10.7.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455
Description
Describe what this change achieves
Issues Resolved
List any existing issues this PR resolves
Check List
## Unreleased