Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Highpop map: Convex recreational complex #33346

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

New Highpop map: Convex recreational complex #33346

wants to merge 59 commits into from
+237,411 −4

Conversation

Spessmann
Copy link
Contributor

@Spessmann Spessmann commented Nov 16, 2024 •
edited
Loading

About the PR

Adds a new highpop map, Convex recreational complex
Its done. Still needs to be reviewed. The random 5x5 rooms in maints are for #33619 but that can be changed if need be. It has all the normal jobs plus two boxers and two reporters.

last touch ups

  • Name map - convex recreational complex
  • Update other yml map stuff (needs to be named first)
  • Get review (partial review from maptainers done)
  • Update map from review (update from maptainer's review done)

Will pull out of draft once named and yml is set up right

Why / Balance

we have like two highpop maps plus more (good) maps are good for variety

Media

Most recent photo - Discord
most recent is too big to post on github

Requirements

Changelog

🆑

  • add: Added Convex recreational complex, a large service-oriented highpop map.

@Spessmann Spessmann requested a review from Emisse as a code owner November 16, 2024 06:13
@ss14-map-server
Copy link

This PR contains new or changed maps:

  • test.yml

Maps are being rendered. This comment will be updated if rendering them is done.
11/16/24 06:13

@Spessmann Spessmann marked this pull request as draft November 16, 2024 06:13
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted size/XL Denotes a PR that changes 5000+ lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. labels Nov 16, 2024
@SaphireLattice SaphireLattice added T: New Feature Type: New feature or content, or extending existing content D1: High Difficulty: Extensive codebase knowledge required. A: Mapping Area: Maps, or tools used for mapping and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 16, 2024
@Stewie523
Copy link
Contributor

looks pretty decent right now. looking forward to the progress on this

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • test.yml

Maps are being rendered. This comment will be updated if rendering them is done.
11/16/24 15:34

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • test.yml

Maps are being rendered. This comment will be updated if rendering them is done.
11/16/24 16:34

@Sadie-silly
Copy link
Contributor

The ai core looks cool, and reminds me a bit of a peanut

@cohanna
Copy link
Contributor

cohanna commented Nov 17, 2024

Giga atmos

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • test.yml

Maps are being rendered. This comment will be updated if rendering them is done.
11/17/24 18:12

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • test.yml

Maps are being rendered. This comment will be updated if rendering them is done.
11/17/24 20:32

@Spessmann
Copy link
Contributor Author

forgot red phone

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • test.yml

Maps are being rendered. This comment will be updated if rendering them is done.
11/18/24 02:45

@ss14-map-server
Copy link

This PR contains new or changed maps:

  • test.yml

Maps are being rendered. This comment will be updated if rendering them is done.
11/18/24 03:02

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 3, 2025
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 8, 2025
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emisse Emisse Awaiting requested review from Emisse Emisse is a code owner

Assignees
No one assigned
Labels
A: Mapping Area: Maps, or tools used for mapping Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D1: High Difficulty: Extensive codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted size/XL Denotes a PR that changes 5000+ lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Spessmann @Stewie523 @Sadie-silly @cohanna @Everturning @thebadman4662 @Ko4ergaPunk @everydayeldergod @SaphireLattice