Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved French accent (th sound) #33630

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −3
Open

Improved French accent (th sound) #33630

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f845744
Improved French accent
ObaniGemini Nov 28, 2024
1bbe706
Remove the double consonna part to simplify the code and behaviour
ObaniGemini Dec 1, 2024
06b60b7
French accent: clarify a comment
ObaniGemini Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions Content.Server/Speech/EntitySystems/FrenchAccentSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,28 @@ public string Accentuate(string message, FrenchAccentComponent component)

msg = _replacement.ApplyReplacements(msg, "french");

// replaces th with z
msg = RegexTh.Replace(msg, "'z");

// replaces h with ' at the start of words.
msg = RegexStartH.Replace(msg, "'");

// spaces out ! ? : and ;.
msg = RegexSpacePunctuation.Replace(msg, " $&");

// replaces th with 'z or 's depending on the case
foreach (Match match in RegexTh.Matches(msg))
{
var uppercase = msg.Substring(match.Index, 2).Contains("TH");
var Z = uppercase ? "Z" : "z";
var S = uppercase ? "S" : "s";
var idxLetter = match.Index + 2;

// If th is alone, just do 'z
if (msg.Length <= idxLetter) {
msg = msg.Substring(0, match.Index) + "'" + Z;
} else {
var c = "aeiouy".Contains(msg.Substring(idxLetter, 1).ToLower()) ? Z : S;
msg = msg.Substring(0, match.Index) + "'" + c + msg.Substring(idxLetter);
}
}

return msg;
}
Expand Down
Loading