-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Glasses Fragile and Damage On Slip #34184
base: master
Are you sure you want to change the base?
Conversation
RSI Diff Bot; head commit 8571aaa merging into a13076b Resources/Textures/Clothing/Eyes/Glasses/brokenglasses.rsi
|
Would be cool if there was a visual change to the glasses when they break |
You can make it as if they got somewhat bent around the bridge, shift one of the eyes a pixel lower. |
I can finally make velma 😆 |
behaviors: | ||
- !type:SpawnEntitiesBehavior | ||
spawn: | ||
ClothingEyesGlassesBroken: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The glasses are currently "repairable" via a crafting recipe using the broken glasses and a piece of glass. I'll experiment with using the breakage and repairable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think making them repairable would be the nicer way to do this rather than adding a crafting recipe specifically for glasses.
/// Damage multiplier maximum | ||
/// </summary> | ||
/// <remarks> | ||
/// Will multiply the damage specifier by a random integer from 1 to maximum (non inclusive) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why a random integer and not a float?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My intention was to give the possibility of slipping once to shatter your glasses despite not damaging them previously by doubling the damage. This only required a multiplier of 1 or 2. Otherwise, it very much could be a float.
behaviors: | ||
- !type:SpawnEntitiesBehavior | ||
spawn: | ||
ClothingEyesGlassesBroken: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think making them repairable would be the nicer way to do this rather than adding a crafting recipe specifically for glasses.
About the PR
This PR gives vision correcting glasses a very small chance, 1%, to break when slipping.
This also adds a new pair of glasses: Broken Glasses.
Broken glasses still provide a small amount of vision correction, but only a fraction compared to standard glasses.
This also adds a crafting recipe to replace the glass in a pair of broken glasses.
In general, the
DamageOnSlip
component can be used in general for any piece of clothing and can be customized with a different damage, chance, and multiplier range.This utilizes the destructible component and a damage threshold to handle the end effects, and the
damageonslip
component to damage the clothing.This is my first attempt at making a sprite, so I will accept any critique, especially with the meta.json
Why / Balance
Adds RP potential around glasses as they are a notoriously fragile piece of clothing.
Makes glasses and their care more vital.
Gives the ability to repair broken glasses with a very simple recipe in order to prevent some frustration with them breaking.
Media
velma-2-reduced.mp4
This video does not showcase the glass break sound when the glasses shatter
Requirements
Changelog
🆑