Fix holopads phasing through walls. #34300
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Untriaged
lzk228
added
T: Bugfix
metalgearsloth
approved these changes
Jan 13, 2025
|
I'm not sure it should have opaque? It seems like a very low, floor-level object. It would make sense that lasers also pass over it |
|
Drats. I was only thinking about bullets hitting it but I failed to test even that. I'll take a look at it when I get off. |
|
@Errant-4 Just went in and tested. It appears to function as desired already. Both lasers and bullets pass right through. bullet_test.mp4 |
|
|
followed the artifact analyzer for this one. I don't quite understand how fixtures work so I'm a bit perplexed by this.
github-actions
bot
added
size/S
|
@Errant-4 alright, I've changed the masks to match that of the artifact analyzer. I'm a bit confused on it as the arti analyzer has two fixtures one with hard disabled. Is one of those the mask for when its unanchored? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixes one of the issues of #33986
Why / Balance
The issue is that holopads could be tossed under walls either intentionally or accidentally when being moved. Once under say a reinforced wall, you'd have to deconstruct the wall to get the holopad back.
Technical details
Changes the mask and layer of holopad.yml to TabletopMachineMask and Opaque. Mimics the mask of cell rechargers since the behavior is the same.
Media
holopad_fix.mov
Requirements
Breaking changes
None
Changelog
🆑