Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access configurator debug assert #34330

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Fix access configurator debug assert #34330

merged 4 commits into from
Jan 10, 2025

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Jan 9, 2025

About the PR

Fixes a debug assert raised by the access configurator on modifying door access.

Why / Balance

Technical details

Made GetMainAccessReader return an entity instead of just the component, then fixing the dirty to raise on that entity.

Media

Requirements

Breaking changes

AccessReaderSystem.GetMainAccessReader now gives an entity instead of just the access reader comp.

Changelog

changelogn't

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines. labels Jan 9, 2025
slarticodefast
slarticodefast approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works as intended. Thank you for fixing it!

@slarticodefast slarticodefast self-assigned this Jan 9, 2025
@slarticodefast slarticodefast added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jan 9, 2025
@ScarKy0 ScarKy0 mentioned this pull request Jan 9, 2025
Open
6 tasks
@github-actions github-actions bot added the S: Needs Review Status: Requires additional reviews before being fully accepted label Jan 10, 2025
@Tayrtahn Tayrtahn merged commit dd28f17 into space-wizards:master Jan 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tayrtahn Tayrtahn Tayrtahn approved these changes

@slarticodefast slarticodefast Awaiting requested review from slarticodefast

Assignees

@slarticodefast slarticodefast

Labels
S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScarKy0 @Tayrtahn @slarticodefast