-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bottled drinks and dispensers standardised #34338
base: master
Are you sure you want to change the base?
Bottled drinks and dispensers standardised #34338
Conversation
…mmon ingredients.
I think, if nothing else, this could benefit from some feedback and discussion. For instance, just with the soda dispenser:
A normal small water bottle is still the odd one out, at only 30u volume, but as everyone starts with this I wanted to check before increasing it to 50u, which is what the rest of the soda bottles have. Soda and tonic water both had 100u bottles, so a I made a new 100u water bottle, that they inherit from. Everything new in the soda dispenser is used to make common cocktails that use readily available ingredients, or at least no more difficult to obtain that was already in there. |
It would kind of make sense to have a juice dispenser and a hot drinks dispenser. It all coming out of one soda dispenser seems a bit strange. It would also help solve UI bloat, and remove a lot of stuff that isn't used very often with bartending from the single dispenser. On the other hand, even 1 more dispenser to add to all maps is a bit of a hassle. Not sure how bartenders would feel either. Less clutter, but more dispensers to deal with. |
Sorry to be just venting my thoughts here, but it ocurred to me, that the neatest solution might be to simplify some of the drink and reactions involved in bartending, in it's current state. One shining example is that we have two branded lemon sodas used in cocktails but lemonade is only used in one cocktail, requires its own reaction to mix, and is not included in the soda dispenser. |
About the PR
Corrects a variety of inconsistencies with bottled drinks and the soda dispeser.
Why / Balance
There was a wild array of different containers and volumes used on for the soda dispenser, and the list of drinks they came from.
Drinks like Bloody Mary and Cosmopolitan can now be mixed at round start.
Technical details
Changes the values for most drinks in drinks_bottles.yml
Adds some missing drinks to beverage.yml for the soda dispenser
Makes soda and booze dispensers inherit from ReagendDispenserBase
Media
Requirements
Changelog
Probably. TBA