Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDA uplinks locking while in FTL, while evac exists and on the arrivals terminal #34359

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Callmore
Copy link
Contributor

@Callmore Callmore commented Jan 10, 2025

About the PR

PDA uplinks are automatically locked when FTL is started and cannot be unlocked until they are done.
Also throws up popups when this happens. The popups are only visible to either the person attempting to unlock or to the person holding the PDA when it locks.

update: it now locks while evac is docked, might need more notifications in chat or something
@Errant-4

#34314

Why / Balance

shuttlebombing moment
reduce admin workload moment

Technical details

New component that can be applied to maps that will make the unlock code not unlock called LockableUplinkBlockedMapComponent. Makes uplinks just unable to be unlocked while on those maps.

Media

uplink.mp4

Requirements

Breaking changes

Changelog

🆑

  • tweak: Uplinks can no longer be opened during FTL.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. S: Needs Review Status: Requires additional reviews before being fully accepted labels Jan 10, 2025
@Errant-4
Copy link
Member

Errant-4 commented Jan 10, 2025

You just put its number on this PR without using the specific format that will cause an autoclose. Like this:

#34314

They are now linked referenced

@Errant-4 Errant-4 closed this Jan 10, 2025
@Errant-4 Errant-4 reopened this Jan 10, 2025
@Errant-4
Copy link
Member

Sorry, touchscreen moment

@Callmore
Copy link
Contributor Author

Thanks errant

@Callmore
Copy link
Contributor Author

Callmore commented Jan 10, 2025

You just put its number on this PR without using the specific format that will cause an autoclose. Like this:

#34314

They are now linked

Okay but seriously I just assumed doing that would autoclose the issue

Does it only autoclose if you add fixes before?

@Errant-4
Copy link
Member

You just put its number on this PR without using the specific format that will cause an autoclose. Like this:
#34314
They are now linked

Okay but seriously I just assumed doing that would autoclose the issue

Does it only autoclose if you add fixes before?

Yes there are a few keywords that do that "fixes X" "closes X" not sure about the rest I slways just use "fixes"

@SlimmSlamm
Copy link
Contributor

Force locking uplinks during FTL isn't going to do anything. Shuttle bombing is already against the rules in MRP. It's allowed in LRP still as long as it doesnt cause excessive death. Let's also not completely ruin doing objectives on shuttle. This PR is only going to cause problems.

@SlimmSlamm
Copy link
Contributor

I'd also like to mention they specifly state that DAGDs are allowed to do this still so you are not only adding a feature that is bloat but you are also actively making a feature that completely ruins a rule placed to let DAGDs have more freedom.

@Callmore
Copy link
Contributor Author

Callmore commented Jan 10, 2025

counterpoint, if it's against the rules, why is the player allowed to do it?

there's generally a preference to try and turn rules into mechanics, as it helps reduce admin workload.

you also had the entirety of the shift to do your objectives, that's most of the time at least an hour, game mechanics should discourage doing them on evac during the last 2 minutes instead of the first hour

@Hrosts
Copy link
Contributor

Hrosts commented Jan 10, 2025

Force locking uplinks during FTL isn't going to do anything. Shuttle bombing is already against the rules in MRP. It's allowed in LRP still as long as it doesnt cause excessive death. Let's also not completely ruin doing objectives on shuttle. This PR is only going to cause problems.

  1. It should be against the rules even on LRP.
  2. Enforcing mechanically > having to rely on admin presence and reports
  3. Doing objectives on the shuttle is lame. You had all the time in the world to make the round interesting for others, instead you spent it doing nothing only to try and "win" in the most lazy way possible.

@SlimmSlamm
Copy link
Contributor

3. Doing objectives on the shuttle is lame. You had all the time in the world to make the round interesting for others

I dont think you understand when I literally said you can wake up from cryo seconds before evac and roll syndicate. You can be forced to do them on evac as well even if you had it for over 30 minutes. This is quite literally a bad change and it will only cause bugs in the future with the uplink.

@SlimmSlamm
Copy link
Contributor

counterpoint, if it's against the rules, why is the player allowed to do it?

because its encouraged to do as DAGD? what kind of counterpoint is this supposed to be

@SlimmSlamm
Copy link
Contributor

ou also had the entirety of the shift to do your objectives, that's most of the time at least an hour, game mechanics should discourage doing them on evac during the last 2 minutes instead of the first hour

again. before responding read what i said. you can roll syndicate SECONDS before evac. you can roll it minutes before it. i've rolled syndie with DAGD as evac docked before.

@Callmore
Copy link
Contributor Author

3. Doing objectives on the shuttle is lame. You had all the time in the world to make the round interesting for others

I dont think you understand when I literally said you can wake up from cryo seconds before evac and roll syndicate. You can be forced to do them on evac as well even if you had it for over 30 minutes. This is quite literally a bad change and it will only cause bugs in the future with the uplink.

i agree! this is not good design! however it is one, unrelated to this pr, and two, could probably be fixed the same way that sleeper agents are fixed, just... stop letting them roll while evac is coming

@SlimmSlamm
Copy link
Contributor

lets also mention how there are times where evac gets called 20 minutes into the round due to singulo/tesla. what then? just take away their syndicate status cause fuck them?

@Callmore
Copy link
Contributor Author

i would also like to mention that, while i didn't do it since i didn't want to bikeshed too much, the component for blocking uplinks could be easily added to cc and arrivals if wanted

@metalgearsloth
Copy link
Contributor

lets also mention how there are times where evac gets called 20 minutes into the round due to singulo/tesla. what then? just take away their syndicate status cause fuck them?

If you're getting syndicate onboard the shuttle then you were never doing your objectives anyway.

@Hrosts
Copy link
Contributor

Hrosts commented Jan 10, 2025

lets also mention how there are times where evac gets called 20 minutes into the round due to singulo/tesla. what then? just take away their syndicate status cause fuck them?

There's no need to "fuck them", cause in a case of tesla or singulo being loose everyone's already fucked. These are round-ending cataclysms that break the round for every antagonist and non-antagonist out there. It's bad luck for evertyone, and fixing an annoying and lame practice of shuttlebombing has much larger value than giving the syndies a consolation prize of bombing the shuttle with those few who managed to survive a loose.

@lzk228 lzk228 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content labels Jan 10, 2025
@EthanQix
Copy link

Please deliver feedback without putting it into a burrito wrap of sarcasm, thank you.

Apologies, let me rephrase.

This change is easily worked around by traitors, who can just fill their bag with explosives/carps/whatever before boarding the shuttle (there's no such thing as an efficient sec checkpoint) or even buy a syndie bomb 3 seconds before the shuttle leaves. This is why I mean by it being a bandaid, as shuttlebombings and other mass shuttle destruction are caused by a design flaw in evac that doesn't have a simple mechanics fix.

As long as the assassination targets have a 100% chance to be on the evac shuttle, mass shuttle destruction is an almost 100% greentext strategy and it will keep happening, no matter how many mechanics quickfix PRs we make.

@EthanQix
Copy link

In fact I should probably open an issue on the topic instead of repeating the same argument on said bandaid PRs >.>

@Lyroth001
Copy link
Contributor

Overall preventing shuttlebombing is generally a good thing, will this affect ftling on non-evac shuttles? I.e. salv shittes/sec prisoner transfer etc

@Callmore
Copy link
Contributor Author

okay chat i'm gonna rework this slightly so it can be applied to the emergency shuttle as well instead of being limited to only maps

@Callmore Callmore changed the title PDA uplinks locking while in FTL PDA uplinks locking while in FTL, while evac exists and on the arrivals terminal Jan 10, 2025
@Callmore
Copy link
Contributor Author

description and title updated

@ps3moira
Copy link
Contributor

Should make it ccvar

Turns on and off uplink locking
@Callmore
Copy link
Contributor Author

there is now a cvar

@Callmore
Copy link
Contributor Author

I've just had a mild realisation
uplink implants bypass everything I've done
is it worth it to do something about them...
uggghh

@Mixelz
Copy link

Mixelz commented Jan 11, 2025

Please deliver feedback without putting it into a burrito wrap of sarcasm, thank you.

Apologies, let me rephrase.

This change is easily worked around by traitors, who can just fill their bag with explosives/carps/whatever before boarding the shuttle (there's no such thing as an efficient sec checkpoint) or even buy a syndie bomb 3 seconds before the shuttle leaves. This is why I mean by it being a bandaid, as shuttlebombings and other mass shuttle destruction are caused by a design flaw in evac that doesn't have a simple mechanics fix.

As long as the assassination targets have a 100% chance to be on the evac shuttle, mass shuttle destruction is an almost 100% greentext strategy and it will keep happening, no matter how many mechanics quickfix PRs we make.

If you couple this with a contraband scanner you could quite easily give security the exact tools they need to try and prevent shuttle bombings from happening.
By sheer conicidence I've just put exactly such a machine on a design doc and will include this PR as a reference point for it. :)

@Aisu9
Copy link

Aisu9 commented Jan 11, 2025

Why keeping the idea of objective list when said objective are not even objective but validating list of suggestions?
people don't even try to get creative because there is a set path to achieve each suggestion, this is always the same boring problem.
CMO was assaulted? their suit is missing
RD? their suit or their hand tele
HoS? their shotgun
Captain? nuke codes
Killing ANYONE? waiting shuttle and bomb the hell out of it because escape pods where made useless following the suggestion made by one of the most disliked-now-perma-ban powergamer because they couldn't greentext one night because their target took an escape pod, and also because it is the ONLY WAY to "get" your "objective". also it's funny to make end of round miserable for everyone but yourself because you had to kill 1(ONE) Salvager and couldn't roleplay your way to work cargo.

@GoodWheatley
Copy link
Contributor

because escape pods where made useless following the suggestion made by one of the most disliked-now-perma-ban powergamer because they couldn't greentext one night because their target took an escape pod

Escape pods have never counted as escaping alive for both traitors and crew, I don’t know when people started thinking that they used to.

@Aisu9
Copy link

Aisu9 commented Jan 11, 2025

because escape pods where made useless following the suggestion made by one of the most disliked-now-perma-ban powergamer because they couldn't greentext one night because their target took an escape pod

Escape pods have never counted as escaping alive for both traitors and crew, I don’t know when people started thinking that they used to.

indeed, but it also never counted you as dead/marooned for the purpose of the "objective". but because of that change people do indeed prefer to try and make antagonist fail that objective, and also made it easier for traitor to get their "objective" no matter what because the shuttle will end up either in space dust or molten slag. because they are not punished for doing what you should be considering the last solution. THE solution; while also not bringing ANYTHING to the current round. people cried and keep crying on the little number of PR that added even a small chance for greenshift, only themselves to cause greenshift for 95% of the shifts they are playing(i am indeed considering shift when nothing is happening but shuttle bombing a greenshift because it doesn't matter at this point, i don't know why they are even bothering to grief everyone at round end with explosive. at this point why even keeping traitor as antagonist if all they do is shuttle bombing?)

@insoPL
Copy link
Contributor

insoPL commented Jan 12, 2025

I mean, magicking items out of thin air using uplink always felt gamey to me. Maybe we should implement more RP way of obtaining contra. Easiest way would be to use disposals bins and mailing units as shops, maybe sprinke some "destroyed" mailing units in maints.

@Callmore
Copy link
Contributor Author

could we uh
actually talk about the pr instead of talking about unrelated stuff
thanks

@Callmore
Copy link
Contributor Author

I mean, magicking items out of thin air using uplink always felt gamey to me. Maybe we should implement more RP way of obtaining contra. Easiest way would be to use disposals bins and mailing units as shops, maybe sprinke some "destroyed" mailing units in maints.

I'm gonna be honest, I'm not in a position to write something like that, however your free to try!

@Emisse
Copy link
Contributor

Emisse commented Jan 12, 2025

I disagree with this but I believe the better fix would be to disable uplink purchases rather than locking the pda

@Callmore
Copy link
Contributor Author

I disagree with this but I believe the better fix would be to disable uplink purchases rather than locking the pda

i don't particularly like this idea just because I'm concerned it will interfere with nukies, but if there's a general consensus on it I'll look into doing that instead

@Callmore
Copy link
Contributor Author

I disagree with this but I believe the better fix would be to disable uplink purchases rather than locking the pda

i don't particularly like this idea just because I'm concerned it will interfere with nukies, but if there's a general consensus on it I'll look into doing that instead

i don't want to interfere with loneops since they're unable to do their job if they can't buy any equipment, and i somehow feel it's more okay for them to blow up the shuttle if need be

@superjj18
Copy link

superjj18 commented Jan 13, 2025

Wait escape pods don't count as successful escape to centcomm? If so that's a massive bug that should be fixed. An escape is an escape

@Callmore
Copy link
Contributor Author

Wait escape pods don't count as successful escape to centcomm? If so that's a massive bug that should be fixed

iirc it's intended, if you want to escape you gotta go though evac

@EthanQix
Copy link

Wait escape pods don't count as successful escape to centcomm? If so that's a massive bug that should be fixed. An escape is an escape

It's been intended behavior since infamous, now banned antag roller Sosa complained that he couldn't get greentext every round, as sometimes he just wouldn't find his target.

#17890

@Callmore
Copy link
Contributor Author

okay chat time to mald pr it locking all purchaces after being murdered by two bombs on evac

@Aisu9
Copy link

Aisu9 commented Jan 13, 2025

Wait escape pods don't count as successful escape to centcomm? If so that's a massive bug that should be fixed. An escape is an escape

escape pods brings you to centcomm, thus are meant to count as secondary method to reach centcomm alive.
They are here in emergency case you cannot reach the escape shuttle in time but are all horribly mapped to deliver on their intended purposes(half of the time they are in the deep end of maintenance, other time they are all packed together in the deep end of the station layout, making them nearly unuseable if you don't spend a minute rushing to them).
Each department should have an escape pod mapped in them, and a couple available to the greytiders.

@GoodWheatley
Copy link
Contributor

GoodWheatley commented Jan 14, 2025

Here’s my opinion on the change: It’s a good effort but I really doubt it’s going to make a difference. Anyone who thinks ahead and buys their bombs beforehand is still going to be able to get on the shuttle and set them off.

The only thing this directly nerfs is hardbombing the shuttle, which was already not a good idea since you had to plant it before the shuttle takes off or the crew could just wait out the timer and get off at CC before it blows up.

The reason for this is this searching sixty people before they board the shuttle is a virtually impossible task. Evac docks are not equipped for screening people who are getting on, and even if they were, players are just going to try to get around them because nobody is going to want to get in a massive line to be searched. Even if a would be bomber does consent to being searched, they can just have their bombs in a storage implant and still blow up the shuttle.

Even then, the evac dock isn’t even the only way people can get on: most emergency shuttles have airlocks facing space that anyone with a hardsuit can just walk through. And with everyone in security focusing on trying to screen people at the evac dock, nobody is going to call out the salvager who went in through the airlock and the shuttle is still going to get blown up.

Looking at this PR in a vacuum, I don’t see it actually making a meaningful difference in stopping shuttlebombings because you still have to search and then detain someone to get the bombs.

Even if you consider the contraband detector PR, this can still lead to false positives, the ones baked into the machine and the ones from people carrying contraband that isn’t a bomb, that cause the searches to be slowed down even more. Keep in mind that this all these searches and screenings have to be done in three minutes, otherwise the shuttle is going to leave. You can’t just prescreen people either, because then they can just buy a bomb before the shuttle docks.

The point I’m trying to make here is that short of drastic measures like being unable to prime a bomb on the evac shuttle at all, there is always going to be a way to bomb the shuttle by nature of this being a sandbox game. There’s no singular method of blowing up the evac shuttle, so you’re now entering into an arms race of constantly trying to figure out how to stop this when there’s always another, craftier, way to do it.

And why wouldn’t people do it? It’s the fastest way to get your objective done, it’s the most probable way to ensure your target is going to stay dead, it gives security the least amount of time to arrest you and ruin your greentext, and style points aren’t being tracked.

And if you don’t want to get blown up as a bystander, that’s what escape pods are for in the first place- a way to escape the station without taking the shuttle.

Overall this is just treating the symptoms of the problem instead of actually getting to the source- the kill objective sucks. It not only needs you to figure out how to kill someone without security knowing, but requires you to make sure they stay dead- which encourages either round removing the player, which is usually extremely planning intensive, or killing them when there’s the least amount of time for them to be revived- so bombing them on the shuttle.

And this sucks, because unlike the steal objective, which mostly consists of thieving gloving the the target for their item, this is a very mechanically complex objective to pull off, with a lot of ways to approach it. But requiring the target to stay dead removes most of that creativity in favor of gibbing someone in maints or blowing them up on the shuttle. And unless the kill objective gets changed, shuttlebombing is still going to be the optimal strategy for accomplishing it.

tldr: instead of trying to prevent shuttlebombing change it so shuttlebombing isn’t the best strategy. Rework the kill objective so the target doesn’t need to be dead when the round ends, just that you’ve killed them at some point.

@Callmore
Copy link
Contributor Author

i feel just stating one thing will be the solution is itself misguided
there's multiple reasons people do it, and really they should all be looked into, not just assumed fixing x will solve y

@GoodWheatley
Copy link
Contributor

i feel just stating one thing will be the solution is itself misguided there's multiple reasons people do it, and really they should all be looked into, not just assumed fixing x will solve y

I’m not saying changing the kill objective is going to completely prevent it- there’s always going to be someone who still decides to wait to evac to blow up their target. But in my opinion it’s a cleaner solution than trying to mechanically prevent blowing up the shuttle when there’s a limitless amount of ways to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Balance Change Type: Balance changes through direct value changes, or changes to mechanics that affect it T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.