A rework of Proximity Detector System to fix #34286

[de0rix]

About the PR

In this PR, the ProximityDetectionSystem.cs has been reworked.

It now can match entities if they have at least a single component from the list in yaml (i.e. properly handle component filtering with RequireAll being false), as well as preserving previous functionality of matching entities with all components in the same list.

Some code was also changed to handle tags search in a better way: now it's possible to use tags only as a criteria, as well as dropping the need to mark TagComponent specifically in the list of components in a criteria (because other way, there would be no entities with field Comp containing TagComponent, that is checked for by previous code) and making tags in a criteria work as a whitelist instead of a blacklist.

Why / Balance

This PR fixes #34286 and other similar subsequent issues, where entities that use this system and component need to match entities that have a single component listed in the criteria.

Technical details

All code logic changes are in the system.
Some formatting was changed.

• Error handling was changed to accommodate use case, where only tags are listed.
• Now instead of checking for TagComponent specifically in a entity-component pair when matching entities tags, EntityManager is used for retrieving it.
• CheckForAllComponentsPresent method was changed, as well as it's name and code that prepares data to call it.
• Some comments were added or changed to better describe why code is used or how to use Criteria property of a component.

Media

footage1.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Possible breaking change is in how the matching entities by criteria is handled now. I've tested all of the two locators currently in-game (anomaly and spectral locator), and adjusted their prototypes a little bit to fix the issue #34286 or to better match new changes, but obviously, developers from other forks of the game should adjust their prototypes accordingly if needed.

Previously, it seems like tags criteria worked like a blacklist, so now entities that should be matched should have those listed tags, instead of entities, that should not.

Default for RequireAll is now false, and because now it affects how entities with listed components matched, changes should be made to their prototypes and/or setting this property to be true.

Changelog

🆑

• fix: Anomaly locator not locating anomaly injectors.

[Hrosts]

Wrong PR link in the description I think you wanted #34286

[de0rix]

Wrong PR link in the description I think you wanted #34286

Indeed, thanks!