Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a popup message when ghost Boo action does nothing #34369

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add a popup message when ghost Boo action does nothing #34369

merged 1 commit into from
Jan 10, 2025

Conversation

Tayrtahn
Copy link
Member

About the PR

Adds a simple notification to the player when they use the "Boo!" action as a ghost but it doesn't affect anything.

Why / Balance

Activating the Boo ability and seeing no result feels bad and has led people to think that the ability is broken. Giving the player feedback when the ability fails makes it clear that at least the game is working correctly.

Technical details

The code for the Boo action already tracks the number of entities that reacted. So this just checks if the number is zero and displays a popup on the specific client if it is.

Media

Screenshot 2025-01-10 at 3 03 38 PM

Requirements

Breaking changes

Changelog

Nah.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. labels Jan 10, 2025
@beck-thompson
Copy link
Contributor

beck-thompson commented Jan 10, 2025 •
edited
Loading

love this!! (It also happens to me all the time and like you said new players get confused)

@beck-thompson beck-thompson added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 10, 2025
slarticodefast
slarticodefast approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was confusing sometimes. Thanks for the PR!

@slarticodefast slarticodefast self-assigned this Jan 10, 2025
@slarticodefast slarticodefast merged commit fdc0853 into space-wizards:master Jan 10, 2025
14 checks passed
@Tayrtahn Tayrtahn deleted the ghost-boo-failure-popup branch January 10, 2025 23:03
@lzk228
Copy link
Contributor

lzk228 commented Jan 10, 2025

maybe we could cooldown time if it does nothing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

@slarticodefast slarticodefast

Labels
A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/XS Denotes a PR that changes 0-9 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tayrtahn @beck-thompson @lzk228 @slarticodefast