Fix nonsensical RegEx for name restriction

[HyperB1]

About the PR

Basically I cleaned up the RestrictedNameRegex, mainly by removing unnecessary delimiters (commas) and a backslash, then moved hyphen to the end of the expression for it to not be interpreted as a range of characters.

Why / Balance

Correct regular expression is better than an incorrect one.

Technical details

Unfortunately, for C# and .NET I cannot shorten [A-Za-z0-9] to just \w, as it will include characters from most alphabets and writing systems in unicode.

Clarification for the edited characters:

• - is a range character, has to be taken literally or be at the end, otherwise causes an erroneous expression interpretation.
• No need for , to repeat so much, it's not a separator and names should not have commas in them.
• \\ is just why? It was added alongside the apostrophe symbol in allow ' in character names #28652 for no particular reason. Backslash repeated twice would escape itself and does not seem to affect anything. Replaced by a single backslash \.
• Added a @ delimiter for proper interpretation of meta escape characters and for consistency to avoid further problems.

Tested and works as intended (no warnings as well).

Media

You can see how the new RegEx filters improper characters in this example.

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Uh, IDK, your characters with a name containing a backslash or a comma will no longer contain them.

Changelog

No CL, no fun.

[0x6273]

\\ is just why?

I think it's to escape the -. Putting it at the end also works but it's common practice to always escape to prevent mistakes if more characters are added at the end.

[HyperB1]

I think it's to escape the -.

Unfortunately it just... Escapes itself by repeating twice. I should've mentioned it, my bad.

[0x6273]

I think it's to escape the -.

Unfortunately it just... Escapes itself by repeating twice. I should've mentioned it, my bad.

Really? I'm pretty sure the double backslash is needed in C# string literals, and the actual string that regex sees will only contain one backslash before the -.

Edit: It seems like the best practice for regex strings is to use the @" " string literals, which don't need escaping so it avoids having to double escape. The regex on the next line does that.

[HyperB1]

I'm pretty sure the double backslash is needed in C# string literals, and the actual string that regex sees will only contain one backslash before the -.

Edit: It seems like the best practice for regex strings is to use the @" " string literals, which don't need escaping so it avoids having to double escape. The regex on the next line does that.

Good to know. Matter of fact, I didn't even notice this. I'll go test it. How would you recommend me to edit the expression to properly escape -?

[0x6273]

I'm pretty sure the double backslash is needed in C# string literals, and the actual string that regex sees will only contain one backslash before the -.
Edit: It seems like the best practice for regex strings is to use the @" " string literals, which don't need escaping so it avoids having to double escape. The regex on the next line does that.

Good to know. I'll test it. How would you recommend me to edit the expression to properly escape -?

Change it to a @" " string literal (like the regex on the next line) and escape it with a single backslash.

[slarticodefast]

Looks good to me, thanks for the fix!