Weapon resizing

[Nox38]

About the PR

Added custom dimensions to every firearm, for better realism. Slightly nerfs the satchel too, by making it less able to carry a full-length assault rifle.

Why / Balance

This started as simply "why isn't the Enforcer 1x5?" and was quickly followed by other strange questions like "why is the assault rifle a square?". This has led me to change every single gun to have a somewhat more realistic and balanced inventory size.

Technical details

Custom dimensions were added to the item component of every firearm.

Media

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Changelog
🆑 Nox38

• tweak: The compact SMGs (C20r, WT550, Atredies, Disabler SMG) are now 2x3.
• tweak: The heavier pump shotguns (Enforcer & Kammerer) are 2x5.
• tweak: The China Lake and L6 are big at 3x6. Your back slot is suggested but not technically required.
• tweak: The assault rifles take up a bit less space at 3x5.
• tweak: The Hristov folds up to just 3x5 to fit into a briefcase. The 28-inch barrel probably splits in half or something for this, idk.
• tweak: Energy carbines (Laser & pulse) are much more portable at 2x5.
• tweak: Energy rifles (X-ray, Laser cannon, Pulse) are somewhat more portable at 2x6.
• tweak: The advanced laser pistol and antique laser pistol are now 2x2 to fit their models (Both can fit in your pocket now!).
• tweak: All pistol-gripped pistols are now pistol-shaped (like the svalinn).
• tweak: Renamed 'laser rifle' to 'laser carbine' to better match its own ID and it's smaller size.
• tweak: Rotated retro laser pistol's sprite to actually fit the pistol shape (thanks ItzChilde!)
• tweak: RPG-7 and handheld cannon are now ginormous. That is not going in your bag.
  -->

[kosticia]

Great PR! But in my opinion satchels will be so much useless for antagonists and security, because biggest part of guns will be so much big for them.

[Nox38]

Great PR! But in my opinion satchels will be so much useless for antagonists and security, because biggest part of guns will be so much big for them.

I'm not sure what guns would still work as 4 long besides the SMGs and the bulldog. The goal isn't to make the satchel useless for those roles, but make satchel vs backpack more of a serious question than satchel being better always. If you have any change suggestions let me know!

[IProduceWidgets]

You'll have to double check it works because I remember there being issues with some visualizers & storage sprite changes in the past, but the pistols would look a lot better offset.

space-station-14/Content.Shared/Item/ItemComponent.cs

Line 62 in 5fff6bb

public Vector2i StoredOffset;

Similarly, the mosin and hristov probably need non-diagonal sprites instead of just making the inv size bigger

[Nox38]

You'll have to double check it works because I remember there being issues with some visualizers & storage sprite changes in the past, but the pistols would look a lot better offset.

Ive been wanting to do this, but don't know where would I find/change each item's offset?

Similarly, the mosin and hristov probably need non-diagonal sprites instead of just making the inv size bigger

unfortunately I do not know how to make/edit sprites, but I like the idea.
The Hristov isn't a huge deal in my opinion because you'd need to disassemble it to fit it in a bag in the first place, explaining the square-er shape, but the Mosin could definitely use a horizontal sprite.

[LaCumbiaDelCoronavirus]

I feel like the enforcer, bulldog and Drozd should keep their original size, as they took large amounts of space in bags to account for how good they are as weapons by themselves. The SMGs (other than drozd, but especially C20s) should really also be longer so that you can't fit, what, 6 of them in one satchel, let alone a bag.
Other than that it looks like a nice PR!

[K-Dynamic]

I feel like the point of gridinv was to standardise sizes, this is going in the opposite direction

[ArtisticRoomba]

I feel like the point of gridinv was to standardise sizes, this is going in the opposite direction

The reason why GridInv has the same sizes for a lot of items is actually because they're inherited from the default sizes of small, medium, large, etc. Expanding the sizes into more unique shapes encourages creativity and funny tetris inventory management which is more fun IMO.

[pheenty]

Syndie shoulder holster should definitely be changed somehow if this gets merged, something like a literal slot for a gun would work (like the jackboots have a slot for a pistol)

[github-actions]

RSI Diff Bot; head commit 1d2833c merging into e271a5a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Guns/Battery/laser_retro.rsi

State	Old	New	Status
base			Modified
mag-unshaded-0			Modified
mag-unshaded-1			Modified
mag-unshaded-2			Modified
mag-unshaded-3			Modified
mag-unshaded-4			Modified