Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cortical stacks for Vox #34417

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

MissKay1994
Copy link
Contributor

@MissKay1994 MissKay1994 commented Jan 13, 2025

About the PR

There's not a lot unique about Vox, and a common topic with Vox players is the fact that instead of a regular brain, they have a cortical stack. This is not the case currently in SS14, and so I decided it's about time someone actually PR's Vox having their cortical stack/vox brain. Discussion with a few people made them see excited to see this being done.

The Vox stack is unique in this, in that fact is does not require an MMI to be inserted into a borg.

Why / Balance

The only major changes this brings are the ability to directly insert a vox stack directly into a borg.

Technical details

There's not much code change, just sprites and a new organ (OrganVoxBrain)

Media

2025-01-13.05-18-28.mp4

image

Requirements

Breaking changes

N/A

Changelog
🆑

  • add: Vox now have cortical stacks.
  • tweak: Vox now no longer require an MMI

@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. labels Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

RSI Diff Bot; head commit 30408de merging into 9d5ef57
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Mobs/Species/Vox/organs.rsi

State Old New Status
brain Added

Edit: diff updated after 30408de

Copy link
Member

@Errant-4 Errant-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally in favor of the idea, but there are some technical issues

-This is slightly unfair since Role Types were merged just a two days ago, but: Nothing handles changing the role type of these brains to Silicon when they are put into the borg body, so it simply does not happen. (For borged crew, this is based on being inserted into an MMI) It's not yet literally a Rule, that what you see on your Character screen is the role you are, but is a reasonable player reaction. This will possibly become an explicit rule in the near future.
Thus, this would more or less mean that borged vox were not required/allowed to follow their laws, since they are not actually Silicon

-The vox stack can be placed in an MMI. Not sure if this is intended or not, since it DOES give them the additional ability to talk even without a borg body, but is otherwise a bit strange/misleading, especially with the lack of in-game signaling that it is possible to directly put them in a borg

@Errant-4
Copy link
Member

Errant-4 commented Jan 13, 2025

The simplest way to resolve this would probably be if the player got a new silicon mind role when they are gibbed and the vox brain entity spawns, but that's a slightly negligent solution. It would only work because there is no way to come back from being gibbed - for now. If it was possible to put the brain into a new organic body, it would need additional code to then lose that silicon mindrole.
Emagged borg body interactions work normally on this brain, except of course that they revert to their pre-borg role type when removed from an emagged body, instead of reverting to silicon.

@Errant-4 Errant-4 added S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. A: Character/Species Area: Player characters and species features and content. A: Silicons Area: Relates to Silicon roles, including AI. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 13, 2025
@MissKay1994
Copy link
Contributor Author

MissKay1994 commented Jan 13, 2025

-The vox stack can be placed in an MMI. Not sure if this is intended or not, since it DOES give them the additional ability to talk even without a borg body, but is otherwise a bit strange/misleading, especially with the lack of in-game signaling that it is possible to directly put them in a borg

This is not actually something that can be fixed by me. This is an issue with the C# code for MMI's. I tried to add a blacklist to MMI's and it threw a huge fit about there being a whitelist and a blacklist while loading. The MMI needs to have code that rejects the BorgBrain component because all the checks of borg stuff are done in the C# code.

I will work on the mind role stuff and see what I can do to try to make the vox stack silicon in a borg chassis.

@MissKay1994 MissKay1994 requested a review from Errant-4 January 14, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Character/Species Area: Player characters and species features and content. A: Silicons Area: Relates to Silicon roles, including AI. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted S: Undergoing Maintainer Discussion Status: Currently going through an extended discussion amongst maintainers, as per procedure. size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants