Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added chemMaster search bar #34452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added chemMaster search bar #34452

wants to merge 1 commit into from
+150 −170

Conversation

PROG-MohamedDwidar
Copy link

@PROG-MohamedDwidar PROG-MohamedDwidar commented Jan 15, 2025 •
edited
Loading

makes it easy for chemists to do their work by having a search bar for the buffer

why:
a job is dependent on it

what i did:
edited the chemMasterWindow.xaml and chemMasterWindow.xaml.cs for a simple search bar

image

image

@PROG-MohamedDwidar
added chemMaster search bar
8fae534 
makes it easy for chemists to do their work
@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: UI Changes: Might require knowledge of UI design or code. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 15, 2025
@beck-thompson beck-thompson added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: New Feature Type: New feature or content, or extending existing content D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Medical Area: Medical department, including Chemistry labels Jan 15, 2025
@PJB3005
Copy link
Member

PJB3005 commented Jan 15, 2025

This falls inline with my other thoughts about the chemmaster: it would be better if the chemmaster wasn't used for this purpose. Having a search bar is not a good solution IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Medical Area: Medical department, including Chemistry Changes: UI Changes: Might require knowledge of UI design or code. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PROG-MohamedDwidar @PJB3005 @beck-thompson