Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separates frost oil into coldsauce and frost oil #34458

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Boaz1111
Copy link
Contributor

@Boaz1111 Boaz1111 commented Jan 15, 2025

About the PR

I separated Frost Oil into Coldsauce and frost oil. Also added a recipe to make coldsauce, being the same as the hotsauce recipe, but with frostoil.

Why / Balance

This change has multiple reasons behind it:

  1. Parity with regular chili peppers. Regular chili peppers, when ground, give capsaicin oil. The condiment packets give hotsauce, not capsaicin oil. This makes sense. Chilly peppers, however, when ground, gave frost oil. Makes sense, yeah? Well, the condiment packets also gave frost oil, despite being named coldsauce. Weird.
  2. Add Reagent gold and silver solification with frost oil #33239 will add a reaction with frostoil. This is a cool reaction, but being able to just order condiment packets and use those kind of trivialise it.

Technical details

Media

Requirements

Breaking changes

Frostoil got renamed to FrostOil

Changelog

🆑

  • add: New Reagent: Coldsauce! It can be made using the Frost Oil from Chilly Peppers, similar to Hotsauce from Capsaicin Oil!
  • tweak: Coldsauce packets and bottles now contain Coldsauce, instead of Frost Oil.

@Boaz1111 Boaz1111 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Service Area: Service department, including cooking, botany, etc labels Jan 15, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. and removed size/S Denotes a PR that changes 10-99 lines. labels Jan 15, 2025
@Aeshus Aeshus removed the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Jan 15, 2025
@Aeshus Aeshus self-assigned this Jan 15, 2025
Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR fellow maintainer!

I just had some nitpicks that aren't blocking, feel free to address them/not if you so choose.

Everything else looks good!

@Aeshus
Copy link
Contributor

Aeshus commented Jan 16, 2025

nitpick (non-blocking,optional): As a side note, I think the current changelog is a little wordy, as you can instead have something like "Coldsauce can now be made using the Frost Oil from Chilly Peppers, similar to Hotsauce from Capsaicin Oil."

@Boaz1111
Copy link
Contributor Author

Like, have that as the entire CL? Bc that misses the part of the bottle and packet no longer containing frost oil

@Boaz1111
Copy link
Contributor Author

Gonna handle the requested changes later

@Aeshus
Copy link
Contributor

Aeshus commented Jan 16, 2025

Like, have that as the entire CL? Bc that misses the part of the bottle and packet no longer containing frost oil

It’s just a suggestion, so you don’t need to use it if you think there’s any issues.

Though, you could also make a “tweak” entry to note that it now actually gives coldsause instead of frost oil.

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines. label Jan 16, 2025
Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes.

I just have some other nitpicks and maybe a solution to the failing tests.

I'm not on my computer right now, so I'm just guessing on the solution.

Cold: 1
- !type:PopupMessage
type: Local
messages: [ "capsaicin-effect-light-burn" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: I think we should probably have a separate message than capsaicin, or at least a different localization id.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the capsaicin effect this uses is just a slight tingle in your throat, which feels fine?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: I think it would be fine to have the same message, but other languages may have different words for a cool minty tingling and a hot spicy tingling, so I would like to give them the ability to localize more easily.

suggestion: I would just copy the localization messages and change the ID to `frost-oil-effect-light-burn" (or an equivalent string of your choosing).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You raise a good point, I'll do it once I'm home

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Service Area: Service department, including cooking, botany, etc Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants