Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BorgChassis transfer their mind to a dropped BorgBrain fix #34464

Merged
merged 1 commit into from
Jan 16, 2025
Merged

BorgChassis transfer their mind to a dropped BorgBrain fix #34464

merged 1 commit into from
Jan 16, 2025

Conversation

ScarKy0
Copy link
Contributor

@ScarKy0 ScarKy0 commented Jan 16, 2025

About the PR

When an entity with BorgChassis puts down an item that has BorgBrain on it their mind gets trasnferred to the same item. This PR fixes that.

Why / Balance

weird bug

Technical details

added a check to see whether the brain is being removed from the correct slot

Media

Requirements

Breaking changes

Changelog

None, extreme edgecase as borgs dont even have hands (was asked to fix this by an admin)

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. labels Jan 16, 2025
@ScarKy0 ScarKy0 added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Silicons Area: Relates to Silicon roles, including AI. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 16, 2025
slarticodefast
slarticodefast approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@slarticodefast slarticodefast merged commit cec5816 into space-wizards:master Jan 16, 2025
14 checks passed
@ScarKy0 ScarKy0 deleted the borgs-transfer-their-mind-to-held-posibrains branch January 16, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees
No one assigned
Labels
A: Silicons Area: Relates to Silicon roles, including AI. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScarKy0 @slarticodefast