-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soda vending ads and goodbyes v2 #34466
Open
Alpaccalypse
wants to merge
8
commits into
space-wizards:master
Choose a base branch
from
Alpaccalypse:vending-adverts-soda-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Soda vending ads and goodbyes v2 #34466
Alpaccalypse
wants to merge
8
commits into
space-wizards:master
from
Alpaccalypse:vending-adverts-soda-v2
+171
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
Denotes a PR that changes 100-999 lines.
S: Untriaged
Status: Indicates an item has not been triaged and doesn't have appropriate labels.
Changes: No C#
Changes: Requires no C# knowledge to review or fix this item.
labels
Jan 16, 2025
You can read comments, from me, about the changes and input from other contributers at the old, closed PR, here: #34215 |
Aeshus
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I just had some brief nitpicks for the advertisements, and I'll be back later to review the rest.
Or a capital T and C... You are right of course. Corrected. Co-authored-by: Thomas <[email protected]>
…nding-adverts-soda-v2
…h capitalisation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changes: No C#
Changes: Requires no C# knowledge to review or fix this item.
S: Untriaged
Status: Indicates an item has not been triaged and doesn't have appropriate labels.
size/M
Denotes a PR that changes 100-999 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Gives all branded soda vendors their own advertising and purchase chatter.
Why / Balance
All soda vending machines share the same set of adverts and goodbyes, this can get quite repetitive and doesn't always make complete sense for the specific drinks that were vended. This makes each branded machine have its own set of advertising and purchase dialogue.
Technical details
(v2 of a closed PR which was getting out of hand with Git Bash errors)
vending_machines.yml
,goodbyes.yml
, andadvertisements.yml
as well ascola.ftl
andsovietsoda.ftl
Media
My favourite, thanks for the suggestion:
Requirements
Breaking changes
Changelog
None. Flavour/cosmetic, with no impact on gameplay.