Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soda vending ads and goodbyes v2 #34466

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Alpaccalypse
Copy link
Contributor

@Alpaccalypse Alpaccalypse commented Jan 16, 2025

About the PR

Gives all branded soda vendors their own advertising and purchase chatter.

Why / Balance

All soda vending machines share the same set of adverts and goodbyes, this can get quite repetitive and doesn't always make complete sense for the specific drinks that were vended. This makes each branded machine have its own set of advertising and purchase dialogue.

Technical details

(v2 of a closed PR which was getting out of hand with Git Bash errors)

  • Adds new .ftl files for each branded vendor
  • Edits vending_machines.yml, goodbyes.yml, and advertisements.yml as well as cola.ftl and sovietsoda.ftl

Media

image
image
image
image
image
image
image

My favourite, thanks for the suggestion:
image

Requirements

Breaking changes

Changelog
None. Flavour/cosmetic, with no impact on gameplay.

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Jan 16, 2025
@Alpaccalypse
Copy link
Contributor Author

You can read comments, from me, about the changes and input from other contributers at the old, closed PR, here: #34215

Copy link
Contributor

@Aeshus Aeshus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I just had some brief nitpicks for the advertisements, and I'll be back later to review the rest.

Resources/Locale/en-US/advertisements/vending/cola.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/advertisements/vending/pwrgame.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/advertisements/vending/pwrgame.ftl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants