-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Parcel Wrap #34471
base: master
Are you sure you want to change the base?
Adds Parcel Wrap #34471
Conversation
RSI Diff Bot; head commit f2f3c1c merging into 5d9311d Resources/Textures/Objects/Misc/ParcelWrap/parcel_wrap.rsi
Resources/Textures/Objects/Misc/ParcelWrap/wrapped_parcel.rsi
|
The RSI test failure is complaining about the licenses I've used. TG station's repo's license is AGPL-3.0 . Does that not cover the sprites as well? What should I use instead? |
Use CC license Can you double-check the attribution of the art assets? I think the main page of the tg repo states sprites are CC or something, with AGPL applying to code. |
update attribution on modified `unwrapped` sprite to better conform to CC's guidance
About the PR
Adds Parcel Wrap, which can wrap items into nice little parcel boxes :)
(Many thanks to @lvvova1 , who put together a previous PR which I referenced quite a lot: #7974 )
AfterInteractEvent
) or used via aUtilityVerb
, which enables wrapping things which have storage, which'd eat the wrap rather than use it.UseInHandEvent
) or via anInteractionVerb
, which enables unwrapping things which are too big to pick up (currently not strictly necessary).Why / Balance
More ways to hide bombs is more fun. Also I want mail to be more of a thing, and this moves in that direction.
Technical details
ParcelWrapComponent
WrappedParcelComponent
ParcelWrappingSystem
WrappedParcel
s in such a way that they copy the size of the wrapped item, which guards against size-arbitrage.WrappedParcel
entity prototypeMedia
https://github.com/user-attachments/assets/f8dc8d13-f295-468c-9c17-7973a1f37e26
(Known bugs in this media: popup refers to the parcel rather than the contents; wrapping in a container can be jank when things have unusual shapes)
https://github.com/user-attachments/assets/fef7de45-ab09-47f6-a571-a8af8d3cd782
(Demos fixes to the bugs in the previos)
Requirements
Breaking changes
All new stuff
Changelog
🆑