Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two zombie bugs #34472

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IProduceWidgets
Copy link
Contributor

@IProduceWidgets IProduceWidgets commented Jan 16, 2025

About the PR

I identified two bugs with zombies and fixed them.

  • Vox health regen from Give vox health regen for poison below 20 damage #33722 was the same strength as the poisoning effect from the PendingZombieComponent meaning Vox would never naturally succumb to the virus. This is bad because it prevents zombies from snowballing, but also because it means Vox could be II forever with no issues which was not intended. Solution: make the poison effect from zombie virus slightly stronger to compensate.
  • All zombies were erroneously initialized with the grace period of Initial Infected. This made the zombie virus really really slow by letting anyone bit by a zombie wait 15 minutes before they start taking damage. Solution: Non-Initial Infected zombies no longer get a grace period.

Why / Balance

I squash bug.
This will make zombies virus scarier and faster.
It only matters if you survive a fight with a zombie.

Technical details

Media

Requirements

Breaking changes

Changelog

🆑

  • fix: Vox are no longer immune to the zombie virus under certain circumstances
  • fix: The zombie virus no longer provides non-Initial Infected an undue grace period before poisoning them.

@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted labels Jan 16, 2025
@pheenty
Copy link
Contributor

pheenty commented Jan 16, 2025

Buffing it two times is definitely not "make it slightly stronger", I don't even think Vox being kinda immune to it is an issue, yet the second fix is nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/S Denotes a PR that changes 10-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants