Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ghost visibility #34474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ghost visibility #34474

wants to merge 1 commit into from
+87 −100

Conversation

ElectroJr
Copy link
Member

About the PR

Updates ghost system so that ghosts are invisible by default.

Technical details

Revenants made ghosts default to being visible instead of invisible, while relying on PVS visibility masks to prevent clients from seeing them, but that obviously doesn't work when PVS is disabled and can introduce bugs (e.g., see space-wizards/RobustToolbox/pull/5598).

Ghost sprite visibility and PVS visibility masks are now configurable via GhostSystem.SetVisible, and revenants now use that.

Requirements

🆑

  • fix: Fixed ghosts sometimes being visible when they shouldn't be.

@ElectroJr ElectroJr added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. A: Core Tech Area: Underlying core tech for the game and the Github repository. labels Jan 17, 2025
@github-actions github-actions bot added S: Needs Review Status: Requires additional reviews before being fully accepted S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Jan 17, 2025
@Aeshus Aeshus added D2: Medium Difficulty: A good amount of codebase knowledge required. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

@nikthechampiongr nikthechampiongr Awaiting requested review from nikthechampiongr nikthechampiongr is a code owner

@crazybrain23 crazybrain23 Awaiting requested review from crazybrain23 crazybrain23 is a code owner

Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElectroJr @Aeshus