39 add fuv dark monitors #73
Conversation
# Conflicts: # cosmo/filesystem.py # cosmo/monitor_helpers.py
# Conflicts: # cosmo/monitors/dark_monitors.py
# Conflicts: # cosmo/filesystem.py
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 92.68% 91.85% -0.83%
==========================================
Files 18 18
Lines 1476 1498 +22
==========================================
+ Hits 1368 1376 +8
- Misses 108 122 +14
Continue to review full report at Codecov.
|
|
feb 14th draft actually outputs a plot. I ran into issues with using find_files in the data models portion where I keep getting an empty dataframe. As a temporary fix, I am using what Camellia used in her NUV dark model. I'll work on that next |
|
I figured out the issue with the dark counts at zero! When creating an FUVA plot, data from FUVB was still being included but just set to zero?? I don't really know. But anyway, I put in a check for the correct segment in the get_data method and this resolved the issue. |
|
@dzhuliya Nice work! This is really great progress. |
|
thanks! Setting subdir_pattern to None was all that it took and now find_files works for me again. I added the bottom monitor just to see what changes would need to be made for each region. Now I can probably work on just generalizing it? Since the only changes I need to make for each region monitor are the xcorr,ycorr values and which segment |
|
So now there are separate working monitors for each segment and region combo. But I think I am going to have to change how things are grouped if I want to have all the FUVA plots together on one page w/ buttons or something. I'll think about this some more... |
|
|
||
| location = (1060, 1260, 296, 734) | ||
| output = COS_MONITORING | ||
| docs = "https://spacetelescope.github.io/cosmo/monitors.html#fuv-dark-rate-monitors" |
There was a problem hiding this comment.
Just remember to name the section like that when you write the documentation, otherwise the link won't work 😆
cosmo/monitors/dark_monitors.py
Outdated
| class FUVALeftDarkMonitor(FUVDarkMonitor): | ||
| """FUVA dark monitor for left edge""" | ||
| name = 'FUVA Dark Monitor - Left' | ||
| data_model = FUVDarkDataModel | ||
| segment = 'FUVA' | ||
| location = (1060, 1260, 296, 734) | ||
|
|
||
| def store_results(self): | ||
| # TODO: Define results to store | ||
| pass | ||
|
|
||
| def track(self): | ||
| # TODO: Define something to track | ||
| pass | ||
| class FUVATopDarkMonitor(FUVDarkMonitor): | ||
| """FUVA dark monitor for top edge""" | ||
| name = 'FUVA Dark Monitor - Top' | ||
| data_model = FUVDarkDataModel | ||
| segment = 'FUVA' | ||
| location = (1060, 15250, 660, 734) | ||
|
|
||
|
|
||
| class FUVARightDarkMonitor(FUVDarkMonitor): | ||
| """FUVA dark monitor for right edge""" | ||
| name = 'FUVA Dark Monitor - Right' | ||
| data_model = FUVDarkDataModel | ||
| segment = 'FUVA' | ||
| location = (15119, 15250, 296, 734) | ||
|
|
||
|
|
||
| class FUVAInnerDarkMonitor(FUVDarkMonitor): | ||
| """FUVA dark monitor for inner region""" | ||
| name = 'FUVA Dark Monitor - Inner' | ||
| data_model = FUVDarkDataModel | ||
| segment = 'FUVA' | ||
| location = (1260, 15119, 375, 660) | ||
|
|
||
|
|
||
| class FUVBBottomDarkMonitor(FUVDarkMonitor): | ||
| """FUVB dark monitor for bottom edge""" | ||
| name = 'FUVB Dark Monitor - Bottom' | ||
| data_model = FUVDarkDataModel | ||
| segment = 'FUVB' | ||
| location = (809, 15182, 360, 405) | ||
|
|
||
|
|
||
| class FUVBLeftDarkMonitor(FUVDarkMonitor): | ||
| """FUVB dark monitor for left edge""" | ||
| name = 'FUVB Dark Monitor - Left' | ||
| data_model = FUVDarkDataModel | ||
| segment = 'FUVB' | ||
| location = (809, 1000, 360, 785) | ||
|
|
||
|
|
||
| class FUVBTopDarkMonitor(FUVDarkMonitor): | ||
| """FUVB dark monitor for top edge""" | ||
| name = 'FUVB Dark Monitor - Top' | ||
| data_model = FUVDarkDataModel | ||
| segment = 'FUVB' | ||
| location = (809, 15182, 740, 785) | ||
|
|
||
|
|
||
| class FUVBRightDarkMonitor(FUVDarkMonitor): | ||
| """FUVB dark monitor for right edge""" | ||
| name = 'FUVB Dark Monitor - Right' | ||
| data_model = FUVDarkDataModel | ||
| segment = 'FUVB' | ||
| location = (14990, 15182, 360, 785) | ||
|
|
||
|
|
||
| class FUVBInnerDarkMonitor(FUVDarkMonitor): | ||
| """FUVB dark monitor for inner region""" | ||
| name = 'FUVB Dark Monitor - Inner' | ||
| data_model = FUVDarkDataModel | ||
| segment = 'FUVB' | ||
| location = (1000, 14990, 405, 740) |
There was a problem hiding this comment.
The question of having individual monitors per "slice" is something that should probably be posed to whoever is providing science/instrumentation support to the monitors group. This is useful because it'd be trivial to run whichever ones of these that a user wants, and there can be customization on what's being tracked, plotted etc for the individual components, so on that front this is great.
However, if it turns out that the quantity being tracked is something that comes from the "overall" FUVA Dark and the only thing desired from the "slices" are the figures, then it'd make more sense to have the one monitor with complex plots.
Resolves #157
Resolves #39