Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove minpin on bqplot-image-gl #3232

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

bmorris3
Copy link
Contributor

@bmorris3 bmorris3 commented Oct 18, 2024

Description

glue-viz/glue-jupyter#470 just got merged into glue-jupyter, which bumps up their pin on bqplot-image-gl. jdaviz has a different minpin on bqplot-image-gl, which causes the devdeps tests to fail. This PR removes jdaviz's pin on bqplot-image-gl, so glue-jupyter can handle it.

We'll also need to bump the pin on glue-jupyter when it is next released.

update on Fri Oct 18 @ 3pm: there was a bug in the version number in the bqplot-image-gl release of v1.5.0, so our devdeps test is failing even without the bqplot-image-gl pin in jdaviz. This PR is now blocked by merge and release of glue-viz/bqplot-image-gl#110.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@bmorris3 bmorris3 added this to the 4.0.1 milestone Oct 18, 2024
@bmorris3 bmorris3 added trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive labels Oct 18, 2024
@kecnry kecnry added the 💤backport-v4.0.x on-merge: backport to v4.0.x label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (9a1fe09) to head (8041682).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3232   +/-   ##
=======================================
  Coverage   88.62%   88.62%           
=======================================
  Files         125      125           
  Lines       18775    18775           
=======================================
  Hits        16639    16639           
  Misses       2136     2136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pllim pllim merged commit 98c227e into spacetelescope:main Oct 21, 2024
25 checks passed
@pllim
Copy link
Contributor

pllim commented Oct 21, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two 💤backport-v4.0.x on-merge: backport to v4.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants