default maximum_cores='none' #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around for known bug when performing multiprocessing with OLS_C fitting.
mperrin
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work around for known bug when performing multiprocessing with OLS_C fitting (spacetelescope/jwst#8842 and spacetelescope/jwst#8710) by defaulting to 1 python process during ramp fitting. In addition, this provides slightly better performance during the ramp-fitting process for the C-fitting routine:
It appears that memory transfer oveheads for python multiprocessing actually slows down the fitting process. The OLS_C functionality inherently utilizing native multiprocessing without having to spawn new threads and is overall much faster when number of python processes is set to 1 (ie., maximum_cores='none').
Fixes #219