Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wcs api call in tests #332

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

There are failures detected by the CI when using the dev version of GWCS. These are due to an incorrect call to the GWCS API that happened to work before when constructing test data. This PR fixes that for the tests.

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner January 3, 2025 17:16
@WilliamJamieson WilliamJamieson requested review from nden and removed request for a team January 3, 2025 17:16
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.57%. Comparing base (35726e9) to head (875357a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   29.57%   29.57%           
=======================================
  Files          36       36           
  Lines        7949     7949           
=======================================
  Hits         2351     2351           
  Misses       5598     5598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nden nden merged commit d6a87c3 into spacetelescope:main Jan 3, 2025
26 of 27 checks passed
@WilliamJamieson WilliamJamieson deleted the bugfix/gwcs_spring_cleaning branch January 3, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants