Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pre_hooks #214

Merged
merged 2 commits into from
Jan 9, 2025
Merged

fix pre_hooks #214

merged 2 commits into from
Jan 9, 2025

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jan 7, 2025

Closes #203

Fixes pre-hooks by packing pre-hook results as tuples so they can be unpacked for subsequent hooks and step.

JWST regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/12659199288
Romancal regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/12659196940

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stpipe@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (a2a8d46) to head (1acb486).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   95.22%   95.27%   +0.04%     
==========================================
  Files          37       37              
  Lines        3165     3177      +12     
==========================================
+ Hits         3014     3027      +13     
+ Misses        151      150       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram requested a review from tapastro January 7, 2025 20:58
@braingram braingram marked this pull request as ready for review January 7, 2025 20:58
@braingram braingram requested a review from a team as a code owner January 7, 2025 20:58
Copy link
Collaborator

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tapastro tapastro merged commit 1f8b39d into spacetelescope:main Jan 9, 2025
18 checks passed
@jdavies-st
Copy link
Contributor

🎉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pre_hooks are broken
3 participants