Improved Watch Dir Monitoring and README #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also more fixes for monitor.py support
coppit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I noticed about the current inotify monitoring is that if I copied a big file from my array into the cache drive watch folder, HandBrake would start working on it before the file was done copying. This pull request uses a monitor.py script that I wrote, which waits for a "stabilization period" before running the command. BTW, the "watchdog" Python module uses inotify underneath.
The monitor.py script also uses a "runas.sh" script, which creates user and group IDs in the container to match the desired host UID/GID. I see that you already set up a "nobody" user in the container to match unraid, but of course that makes this container unraid-specific.
Additional changes: I exposed port 3389 for RDP access, and added a README. I also moved the Watch folder to /Watch, which made more sense to me than making it a subfolder of the config folder.