Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Custom Properties #33

Merged
merged 9 commits into from
Nov 15, 2023
Merged

Adds Custom Properties #33

merged 9 commits into from
Nov 15, 2023

Conversation

bgustafson
Copy link
Contributor

Adds custom properties on tests. This is behind a feature flag still so I will remove from draft status once we get products go ahead to release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

CLA Assistant Lite bot CLA Assistant Lite bot All contributors have signed the COC ✍️ ✅

@bgustafson
Copy link
Contributor Author

I have read the Code of Conduct and I hereby accept the Terms

@bgustafson
Copy link
Contributor Author

recheck

@greatestusername-splunk
Copy link
Collaborator

I merged #31
So you should be able to pull in the new acceptance tests and add custom_properties to those tests.

Thanks!

greatestusername-splunk
greatestusername-splunk approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for your contributions!

@greatestusername-splunk greatestusername-splunk merged commit 41351a6 into splunk:main Nov 15, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greatestusername-splunk greatestusername-splunk greatestusername-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgustafson @greatestusername-splunk