SYN-4606: Handle browser check defaults #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #64
Resolves #38
Resolves #59
Resolves #21
Requires splunk/syntheticsclient#30
Before the change?
wait_for_nav_timeout
is always 50 in the provider but the server-side default is conditional. It's 2000 whenwait_for_nav=true
and 50 whenwait_for_nav=false
. So it's currently causing issues when wait_for_nav is true in the configuration but the wait_for_nav_timeout is not set.max_wait_time
it's working well because the default value is static (always 10000).max_wait_time
andwait_for_nav_timeout
is set automatically for all test types by the provider. Although the API do ignore them for steps where these fields are not applicable, it's not ideal because TF state does not reflect the state on the server.synthetics_create_browser_check_v2
is useless. Any change on the server or in the configuration triggers full replacement of the test and it's not clearly visible in the diff what values are going to be modified.After the change?
Pull request checklist
make testacc
), and pasted in this PR (for bug fixes / features)Acceptance Test Output
Does this introduce a breaking change?
User will see some changes in the Terraform plan -> default values will be removed from the state for tests where they are not applicable.