Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SDK id and version to requests #66

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

fabriziodemaria
Copy link
Member

@fabriziodemaria fabriziodemaria commented Nov 9, 2023

This data is part of the updated Confidence API

@fabriziodemaria fabriziodemaria force-pushed the version-id branch 2 times, most recently from d099aad to a2a8faa Compare November 9, 2023 10:50
@fabriziodemaria fabriziodemaria changed the title Add SDK id and version to requests feat: Add SDK id and version to requests Nov 9, 2023
@fabriziodemaria fabriziodemaria marked this pull request as ready for review November 9, 2023 10:51
@fabriziodemaria fabriziodemaria force-pushed the version-id branch 2 times, most recently from 85548da to 200c2a2 Compare November 9, 2023 12:41
@@ -0,0 +1 @@
version = ${project.version}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pulls data from the Maven artifact or?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabriziodemaria fabriziodemaria merged commit eb97dc7 into main Nov 9, 2023
3 checks passed
@fabriziodemaria fabriziodemaria deleted the version-id branch November 9, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants