Update libintl and fix Exasol and Firebird test errors #860
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning was fixed in v1.35, so only suppress it ourselves for earlier versions.
Pull Request Test Coverage Report for Build 12798571302Details
💛 - Coveralls |
Plug a few more holes in the expectation that Sqitch always raises App::Sqitch::X objects rather than strings, as discovered by some unanticipated test configurations (resolves #858). Also fix a couple of typos and the default URI for Exasol tests.
theory
force-pushed
the
update-libintl
branch
from
3c62314 to
e268fc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check libintl version before suppressing warnings. The warning was fixed in v1.35, so only suppress it ourselves for earlier versions.
Plug a few more holes in the expectation that Sqitch always raises App::Sqitch::X objects rather than strings, as discovered by some unanticipated test configurations (resolves #858). Also fix a couple of typos and the default URI for Exasol tests.