Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cart)!: add setPastTimeToCurrent to update the fulfillment time to ASAP if the requested fulfillment time is in the past #26

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

AustinWu666
Copy link
Contributor

This pull request introduces the setPastTimeToCurrent flag to the Cart SDK, enabling automatic adjustment of past fulfillment times (both pickup and delivery) to ASAP. This feature centralizes the logic for handling past fulfillment times within the SDK, reducing the need for custom validation in front end.

@AustinWu666 AustinWu666 requested a review from a team as a code owner December 5, 2024 20:11
Copy link

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size
lib/index.js 6.42 KB (+1.96% 🔺)
lib/index.umd.cjs 6.58 KB (+1.91% 🔺)

Copy link

github-actions bot commented Dec 5, 2024

📊 Package size report   1%↑

File Before After
lib/index.js 39.4 kB 2%↑40.1 kB
lib/index.umd.cjs 19.4 kB 3%↑20.0 kB
lib/types/api/cart/index.d.ts 14.9 kB 2%↑15.1 kB
Total (Includes all files) 124.0 kB 1%↑125.6 kB
Tarball size 31.8 kB 1%↑32.1 kB
Unchanged files
File Size
lib/api/cart.d.ts 6.2 kB
lib/api/customers.d.ts 1.3 kB
lib/api/places.d.ts 1.3 kB
lib/api/resources.d.ts 1.3 kB
lib/api/template.d.ts 686 B
lib/clients/buyers.d.ts 236 B
lib/helpers/auth.d.ts 239 B
lib/helpers/cookies.d.ts 71 B
lib/helpers/datetime.d.ts 4.8 kB
lib/helpers/item.d.ts 3.7 kB
lib/helpers/location.d.ts 3.9 kB
lib/helpers/money.d.ts 1.5 kB
lib/index.d.ts 875 B
lib/types/api/cart/private.types.d.ts 829 B
lib/types/api/customers/index.d.ts 427 B
lib/types/api/places/index.d.ts 1.9 kB
lib/types/api/resources/index.d.ts 4.2 kB
lib/types/api/resources/private.types.d.ts 60 B
lib/types/api/template/index.d.ts 808 B
lib/types/clients/buyers.private.d.ts 365 B
lib/types/helpers/datetime/index.d.ts 3.9 kB
lib/types/helpers/item/index.d.ts 3.2 kB
lib/types/helpers/location/index.d.ts 3.6 kB
lib/types/helpers/money/index.d.ts 92 B
lib/types/looseobject.d.ts 78 B
LICENSE 1.1 kB
package.json 2.2 kB
README.md 1.6 kB

🤖 This report was automatically generated by pkg-size-action

@AustinWu666 AustinWu666 force-pushed the update-cart-fulfillment-validation branch from a2daa01 to 86a65c5 Compare December 5, 2024 20:37
@AustinWu666 AustinWu666 merged commit 3850535 into alpha Dec 5, 2024
6 checks passed
@AustinWu666 AustinWu666 deleted the update-cart-fulfillment-validation branch December 5, 2024 20:47
Copy link

github-actions bot commented Dec 5, 2024

🎉 This PR is included in version 1.0.0-alpha.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants