Write failing test to track standardrb/standard-performance#8

standardrb · Jun 13, 2023 · a9d7392 · a9d7392
1 parent 95eeb20
commit a9d7392
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/test/fixture/cli/unsafecorrectable-bad.rb b/test/fixture/cli/unsafecorrectable-bad.rb
@@ -1,2 +1,7 @@
 val = :true
 puts val
+
+# Should only be fixed unsafely
+# https://github.com/standardrb/standard-performance/issues/8
+h = {a: 1, b: 2, c: 3}.count { |k, v| v.odd? }
+puts h
diff --git a/test/fixture/cli/unsafecorrectable-good.rb b/test/fixture/cli/unsafecorrectable-good.rb
@@ -1,2 +1,7 @@
 val = true
 puts val
+
+# Should only be fixed unsafely
+# https://github.com/standardrb/standard-performance/issues/8
+h = {a: 1, b: 2, c: 3}.count { |k, v| v.odd? }
+puts h
diff --git a/test/standard/cli_test.rb b/test/standard/cli_test.rb
@@ -36,7 +36,8 @@ def test_unsafely_fixable_is_not_fixed_unsafely
     assert_equal <<~OUTPUT, fake_out.string
       #{standard_greeting}
         test/fixture/cli/unsafecorrectable-bad.rb:1:7: Lint/BooleanSymbol: Symbol with a boolean name - you probably meant to use `true`.
-      standard: Run `standardrb --fix-unsafely` to DANGEROUSLY fix one problem.
+        test/fixture/cli/unsafecorrectable-bad.rb:6:24: Performance/Count: Use `count` instead of `select...count`.
+      standard: Run `standardrb --fix-unsafely` to DANGEROUSLY fix 2 problems.
     OUTPUT
   end