refactor(starknet_sequencer_node): get the shared client based on the execution mode

[nadin-Starkware]

Stack:

• chore(starknet_sequencer_node): add use_remote_client to the Client struct #3240
• refactor(starknet_sequencer_node): remove code duplication from create client macro #3220
• chore(starknet_sequencer_node): remove option from local client #3219
• chore(starknet_sequencer_node): remove option form remote client #3212
• refactor(starknet_sequencer_node): get the shared client based on the execution mode #3209 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

Can we instead add the execution mode to the Client<Request,Response> struct, save it on creation, and avoid passing it to the getter function?

Reviewable status: 0 of 3 files reviewed, all discussions resolved

[nadin-Starkware]

It would create a circular package dependency.

Reviewable status: 0 of 3 files reviewed, all discussions resolved

[Itay-Tsabary-Starkware]

Right. So, instead of holding the specific config (which is defined in the node crate), add a boolean / designated struct, derive its value from the config at the ctor, and use it to distinguish which client to return.

The create-with-config-and-later-get-with-config pattern is suboptimal imo:

1. Require maintaining the config throughout for this purpose (as well)
2. Error prune: might pass one value at ctor and another at getter

Reviewable status: 0 of 3 files reviewed, all discussions resolved

[Itay-Tsabary-Starkware]

Reviewed 1 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nadin-Starkware)

---

crates/starknet_sequencer_node/src/clients.rs line 105 at r3 (raw file):

                } else {
                    None
                }

This should panic

Code quote:

                } else {
                    None
                }

---

crates/starknet_sequencer_node/src/clients.rs line 113 at r3 (raw file):

                } else {
                    None
                }

This should panic

Code quote:

                } else {
                    None
                }

[nadin-Starkware]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_sequencer_node/src/clients.rs line 105 at r3 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

This should panic

Done.

---

crates/starknet_sequencer_node/src/clients.rs line 113 at r3 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

This should panic

Done.