Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(papyrus_p2p_sync): rename stream builder #3231

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

eitanm-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@eitanm-starkware eitanm-starkware force-pushed the eitan/stream_builder_rename branch from 997b0ed to f585ed4 Compare January 12, 2025 09:48
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@eitanm-starkware eitanm-starkware force-pushed the eitan/stream_builder_rename branch from f585ed4 to 91231af Compare January 12, 2025 10:03
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@eitanm-starkware eitanm-starkware force-pushed the eitan/stream_builder_rename branch from 91231af to b7a723e Compare January 12, 2025 11:41
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware)


crates/papyrus_p2p_sync/src/client/stream_builder.rs line 39 at r4 (raw file):

}

pub(crate) trait StreamBuilder<InputFromNetwork>

BlockDataStreamBuilder

@eitanm-starkware eitanm-starkware force-pushed the eitan/stream_builder_rename branch 3 times, most recently from 36af038 to b99d461 Compare January 13, 2025 09:03
@eitanm-starkware eitanm-starkware force-pushed the eitan/stream_builder_rename branch from b99d461 to 68bef45 Compare January 13, 2025 13:22
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@eitanm-starkware eitanm-starkware added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 3181ef1 Jan 13, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants