feat(starknet_sierra_compile_types): add crate #3245
Conversation
|
This change is |
|
Artifacts upload workflows: |
There was a problem hiding this comment.
Reviewed 1 of 5 files at r1.
Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @noamsp-starkware and @ShahakShama)
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware and @ShahakShama)
elintul
force-pushed
the
elin/class-manager/add-sierra-compile-types-crate
branch
from
d4dbf17 to
871869b
Compare
|
Benchmark movements: full_committer_flow performance regressed! |
This is the `_types` crate for the compiler component that the class manager will use (a thin functional wrapper will wrap the existing compiler code in `starknet_sierra_compile` crate, thus will be added there. This is the reason the non-`_types` crate already exists.
elintul
force-pushed
the
elin/class-manager/add-sierra-compile-types-crate
branch
from
871869b to
0e4a6de
Compare
There was a problem hiding this comment.
Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
This is the
_typescrate for the compiler component that the class manager will use (a thin functional wrapper will wrap the existing compiler code instarknet_sierra_compilecrate, thus will be added there. This is the reason the non-_typescrate already exists.