chore(starknet_state_sync): boxing SyncBlock in requests and responses

[lev-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @lev-starkware)

---

crates/starknet_state_sync_types/src/communication.rs line 119 at r1 (raw file):

#[allow(clippy::large_enum_variant)]
pub enum StateSyncResponse {
    GetBlock(StateSyncResult<Box<Option<SyncBlock>>>),

@ShahakShama Box<Option<...>> or Option<Box<...>> ?

Code quote:

Box<Option<SyncBlock>>>

[ShahakShama]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware and @lev-starkware)

---

crates/starknet_state_sync_types/src/communication.rs line 119 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

@ShahakShama Box<Option<...>> or Option<Box<...>> ?

IMO Option<Box<...>

---

crates/starknet_state_sync/src/test.rs line 63 at r1 (raw file):

        panic!("Expected StateSyncResponse::GetBlock::Ok(Box(Some(_))), but got {:?}", response);
    };
    let Some(block) = *boxed_sync_block else {

Unite this with the let above

---

crates/starknet_state_sync/src/lib.rs line 50 at r1 (raw file):

            StateSyncRequest::GetBlock(block_number) => {
                let result: StateSyncResult<Box<Option<SyncBlock>>> =
                    match self.get_block(block_number) {

Use map instead

[ShahakShama]

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware and @lev-starkware)

---

crates/starknet_state_sync_types/src/communication.rs line 119 at r1 (raw file):

Previously, ShahakShama wrote…

IMO Option<Box<...>

After talking with lev that is impossible so we should stay with Box<Option<

[lev-starkware]

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware and @ShahakShama)

---

crates/starknet_state_sync/src/lib.rs line 50 at r1 (raw file):

Previously, ShahakShama wrote…

Use map instead

Done.

---

crates/starknet_state_sync_types/src/communication.rs line 119 at r1 (raw file):

Previously, ShahakShama wrote…

After talking with lev that is impossible so we should stay with Box<Option<

Macro, currently, can deal with Result<Box<Response>, Err> but not with Result<Option<Box<PartialResponse>>, Err>.

[ShahakShama]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)