Issue https://github.com/statOmics/msqrob2/issues/63 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tatModel (msqrobLm)
…s for which the reference level dropped
cvanderaa
reviewed
Aug 26, 2024
…n which the model has no intercept
cvanderaa
reviewed
Aug 29, 2024
| ##### None exported functions from multcomp package is included here to | ||
| ##### During R and Bioc checks | ||
|
|
||
| propagateFalseStatus <- function(vectors, statuses) { |
There was a problem hiding this comment.
Nice attempt to solve the interaction issue, I however can't fully wrap my head around what you are doing. A few comments on the function:
- Could you document the internal function using standard comments so to briefly describe what the function does, and especially what are the expected argument inputs.
- Be very careful with repeat to not allow for infinite loops, I personally prefer a
while()loop although there is still is risk of infinite loops. - I can't see unit tests, but maybe this is in progress
There was a problem hiding this comment.
I added tests, commented the function and changed the code. a97a4e5
|
Let us know when your PR is done, I will then pull your branch and get my hands on your code to see if I can break it through some additional unit tests 😈 😉 |
|
This marks the end of Léopold's internship. The branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. issue:
#63