Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
I was seeing this error when running
contract init
onmain
:This happens because we were trying to use the blocking reqwest client inside of an async runtime, since all of the cli is in an tokio runtime. This doesn't work well together, so I've changed the
init
command to be async and then we're able toawait
the HTTP calls.Known limitations
This won't be an issue once https://github.com/stellar/stellar-cli/pull/1628/files is merged - but we'll still want to move the
init
test into the integration dir - I think that this test was previously not being run.