Skip to content

Commit

Permalink
Fix quickstart invocation (#110)
Browse files Browse the repository at this point in the history
  • Loading branch information
2opremio authored Dec 16, 2024
1 parent 015c661 commit 79454d8
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/Dockerfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ env:
STELLAR_RPC_GIT_REF: https://github.com/stellar/stellar-rpc.git#main
RUST_TOOLCHAIN_VERSION: stable
SOROBAN_CLI_GIT_REF: https://github.com/stellar/soroban-tools.git#main
QUICKSTART_GIT_REF: https://github.com/stellar/quickstart.git#1a831b2350dd3928b60eb745d0862ee19dd2aaaa
QUICKSTART_GIT_REF: https://github.com/stellar/quickstart.git#e1f62bf34cf047156dbb599b3c7dff52283ac696
# leaving sdk npm version blank defaults to whatever npm has for latest version
# rather than build from git source, which is fine for ci test build
JS_STELLAR_SDK_NPM_VERSION:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ This approach allows to run the tests from source code directly on host as go te
3. `soroban` cli, compile or install via cargo crate a version of soroban cli onto your machine and accessible from PATH.
4. target network stack for the tests to access stellar-rpc instance. You can use an existing/running instance if reachable or can use the quickstart image `stellar/quickstart:soroban-dev` from dockerhub to run the latest stable target network stack locally, or build quickstart with specific versions of core, horizon and soroban rpc first [following these instructions](https://github.com/stellar/quickstart#building-custom-images) and run `stellar/quickstart:dev` locally.
```
docker run --rm -it -p 8000:8000 --name stellar stellar/quickstart:dev --standalone --enable-stellar-rpc
docker run --rm -it -p 8000:8000 --name stellar stellar/quickstart:dev --standalone --enable-rpc
```
5. locally checkout stellar/system-test GH repo and go into top folder - `git clone https://github.com/stellar/system-test.git;cd system-test`
Expand Down
8 changes: 4 additions & 4 deletions start
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ print_screen_output "Starting system test ..."
trap printout SIGINT
printout() {
echo "Cancelling and exit."
exit
exit 1
}

trap finish EXIT
Expand Down Expand Up @@ -90,12 +90,12 @@ function main() {

if [ "$VERBOSE_OUTPUT" = "true" ]; then
# redirects all quickstart output to console during test execution
/start --$TARGET_NETWORK --enable-stellar-rpc $ENABLE_SOROBAN_DIAGNOSTIC_EVENTS --logs 2>&1 &
/start --$TARGET_NETWORK --enable-rpc $ENABLE_SOROBAN_DIAGNOSTIC_EVENTS --logs 2>&1 &
else
# don't show any quickstart output on console during test execution
# all quickstart output is redirected(buffering disabled) to log file, which will be dumped to
# console if tests fail.
stdbuf -o0 -e0 /start --$TARGET_NETWORK --enable-stellar-rpc $ENABLE_SOROBAN_DIAGNOSTIC_EVENTS --logs >> $QUICKSTART_LOG_FILE 2>&1 &
stdbuf -o0 -e0 /start --$TARGET_NETWORK --enable-rpc $ENABLE_SOROBAN_DIAGNOSTIC_EVENTS --logs >> $QUICKSTART_LOG_FILE 2>&1 &
fi
fi

Expand Down Expand Up @@ -218,7 +218,7 @@ function stellar_rpc_status () {

if [ $COUNTER -gt 900 ]; then
echo "Waited longer than 15 minutes for rpc, cancelling and exit."
exit
exit 1
fi

sleep 5
Expand Down

0 comments on commit 79454d8

Please sign in to comment.