-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ChIP-Seq Pipeline #22
Open
claymcleod
wants to merge
22
commits into
main
Choose a base branch
from
rfcs/chipseq_workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add deeptools to the list of conda installs
#18) * chip-seq: Update "Aligner choice" with additional projects and details This splits projects into either "open source" or "description only". Under open source projects, this adds ENCODE's second version of their ChIP-seq pipeline (aptly named chip-seq-pipeline2), nf-core's ChIP-seq pipeline, and St. Jude's SEASEQ. Description only projects remain largely the same. Hard wraps in paragraphs were intentionally not included to be consistent with the rest of the document. * chip-seq: Update SEASEQ stable release version
Add read extension parameter to coverage generation
@claymcleod - I can't assign you as a reviewer since you started this PR. |
a-frantz
reviewed
Sep 13, 2023
Comment on lines
+307
to
+309
picard -Xmx${JAVA_HEAP_SIZE}g CleanSam \ | ||
I=${BAM} \ # Input BAM. | ||
O=${OUTPUT_FILENAME} # Output cleaned BAM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be Bash syntax, not WDL syntax
Comment on lines
+323
to
+326
bamCoverage --bam ${MERGED_BAM} \ # Input BAM file | ||
--outFileName ${PREFIX}.bw \ # Output bigwig filename | ||
--outFileFormat bigwig \ # Set output format to bigwig | ||
--numberOfProcessors "max" # Utilize all available processors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bash syntax instead of WDL syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #16.
Rendered