chore: updates to dev-deps and QOL improvements #918
+596
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
edodusi
force-pushed
the
chore/updates-and-qol
branch
from
84e4410 to
2d50232
Compare
alvarosabu
requested changes
Jan 10, 2025
There was a problem hiding this comment.
Hi @edodusi I left couple of question regarding changes on the builds
| @@ -34,7 +34,7 @@ const bundles = [ | |||
| ;(async () => { | |||
| for (const bundle of bundles) { | |||
| await build({ | |||
| configFile: false, | |||
| configFile: 'vite.config.ts', | |||
There was a problem hiding this comment.
Hi @edodusi why this change?
|
|
||
| export default defineConfig(() => ({ | ||
| plugins: [ | ||
| dts({ | ||
| insertTypesEntry: true, | ||
| outDir: 'dist/types', |
There was a problem hiding this comment.
Hi @edodusi why this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Updates and QOL improvements