-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: implement interchaintests #17
Conversation
I'm gonna hold off on this one till we get the others merged if that is okay! I'd like to use this as a test when we have the full CI pipeline in place so we can see what a typical CI run will look like on some actual code changes |
Signed-off-by: Justin Tieri <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a few comments but otherwise lgtm.
since we are merging this can we delete main.go
though? we no longer need that in place since this code will be what we run to test CI. that should also get the linter passing since it complains about fmt.Println
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
We're still going to need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! great work on everything Joel!!
Runs Interchaintests in the CI
This YML does not include steps for running interchaintests on a custom cosmos-based chain, but rather a pre-configured chain with interchaintest. I'm not sure if I need to add that documentation to the workflow as Strangelove's projects aren't really focused on building new cosmos chains as far as I know.