Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: implement interchaintests #17

Merged
merged 8 commits into from
May 29, 2024
Merged

ci: implement interchaintests #17

merged 8 commits into from
May 29, 2024

Conversation

joelsmith-2019
Copy link
Member

@joelsmith-2019 joelsmith-2019 commented May 14, 2024

Runs Interchaintests in the CI
This YML does not include steps for running interchaintests on a custom cosmos-based chain, but rather a pre-configured chain with interchaintest. I'm not sure if I need to add that documentation to the workflow as Strangelove's projects aren't really focused on building new cosmos chains as far as I know.

@joelsmith-2019 joelsmith-2019 self-assigned this May 14, 2024
@joelsmith-2019 joelsmith-2019 requested a review from a team as a code owner May 14, 2024 16:58
@jtieri
Copy link
Contributor

jtieri commented May 18, 2024

I'm gonna hold off on this one till we get the others merged if that is okay! I'd like to use this as a test when we have the full CI pipeline in place so we can see what a typical CI run will look like on some actual code changes

Copy link
Contributor

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a few comments but otherwise lgtm.

since we are merging this can we delete main.go though? we no longer need that in place since this code will be what we run to test CI. that should also get the linter passing since it complains about fmt.Println

.github/workflows/interchain-tests.yml Outdated Show resolved Hide resolved
.github/workflows/interchain-tests.yml Outdated Show resolved Hide resolved
.github/workflows/interchain-tests.yml Outdated Show resolved Hide resolved
.github/workflows/interchain-tests.yml Outdated Show resolved Hide resolved
interchain_test.go Outdated Show resolved Hide resolved
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@joelsmith-2019
Copy link
Member Author

had a few comments but otherwise lgtm.

since we are merging this can we delete main.go though? we no longer need that in place since this code will be what we run to test CI. that should also get the linter passing since it complains about fmt.Println

We're still going to need main.go because a lot of the workflows check for that file. I fixed that linting error by implementing a logger instead.

Copy link
Contributor

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! great work on everything Joel!!

@jtieri jtieri merged commit 8ab59b1 into main May 29, 2024
10 of 11 checks passed
@jtieri jtieri deleted the joel/interchaintest branch May 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants