Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Kubernets 1.21 and above #32

Merged
merged 4 commits into from
Jan 17, 2024
Merged

Conversation

standrewd
Copy link
Contributor

Description
This adds in support for Kubernetes 1.21.0 and above by adding a few tweaks to dynamically use specific version supported fields.

For versions 1.21.0 -> 1.24.0: The serviceName field is required and without it will cause the helm install to fail
For versions 1.22.0 and above: The minReadySeconds is supported and included

Testing
Validated locally using minikube against all versions between and including 1.21.0 -> 1.25.0 by doing a helm install dry run.

Documentation
No documentation needed as this is detected by the version of kubernetes.

@standrewd standrewd requested a review from wfernandes as a code owner January 16, 2024 20:00
Copy link
Member

@wfernandes wfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround on this @standrewd. I just left a few comments, none should be blockers.

charts/orchestrator/Chart.yaml Show resolved Hide resolved
charts/orchestrator/templates/statefulset.yaml Outdated Show resolved Hide resolved
charts/orchestrator/templates/statefulset.yaml Outdated Show resolved Hide resolved
@standrewd standrewd requested a review from wfernandes January 16, 2024 22:25
Copy link
Member

@wfernandes wfernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I left one more comment about the comment block above kubeVersion. And thanks for updating the README as well. That's a good catch.

charts/orchestrator/Chart.yaml Show resolved Hide resolved
@standrewd standrewd merged commit 52d5d34 into main Jan 17, 2024
2 checks passed
@standrewd standrewd deleted the feat/k8s-1-21-support branch January 17, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants