With last version of jackson fasterxml since 2.17.1 to 2.18.0 included in the new spring boot 3.4.1

[RouxAntoine]

look at issue #513

[fhussonnois]

Hey Antoine, it seems there is an issue with the test:

Error: Failures: Error: SpecificStateChangeBuilderTest.shouldProperlySerializeChangeState:68 Unexpected exception thrown: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Conflicting property-based creators: already had explicit creator [constructor for io.streamthoughts.jikkou.core.models.change.SpecificStateChange(4 args), annotations: {interface java.beans.ConstructorProperties=@java.beans.ConstructorProperties({"name", "op", "before", "after"})}, encountered another: [constructor forio.streamthoughts.jikkou.core.models.change.SpecificStateChange (5 args), annotations: {interface java.beans.ConstructorProperties=@java.beans.ConstructorProperties({"name", "op", "before", "after", "description"})} [INFO] Error: Tests run: 233, Failures: 1, Errors: 0, Skipped: 0

I think you can just drop the @ConstructorProperties from the class as well as the constructor.

[RouxAntoine]

Hey Antoine, it seems there is an issue with the test:

Error: Failures: Error: SpecificStateChangeBuilderTest.shouldProperlySerializeChangeState:68 Unexpected exception thrown: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Conflicting property-based creators: already had explicit creator [constructor for io.streamthoughts.jikkou.core.models.change.SpecificStateChange(4 args), annotations: {interface java.beans.ConstructorProperties=@java.beans.ConstructorProperties({"name", "op", "before", "after"})}, encountered another: [constructor forio.streamthoughts.jikkou.core.models.change.SpecificStateChange (5 args), annotations: {interface java.beans.ConstructorProperties=@java.beans.ConstructorProperties({"name", "op", "before", "after", "description"})} [INFO] Error: Tests run: 233, Failures: 1, Errors: 0, Skipped: 0

I think you can just drop the @ConstructorProperties from the class as well as the constructor.

Yes indeed I test it today and seems to be due to duplicate @ConstructorProperties, I can update my pull request. What do you thing is the best @ConstructorProperties to kept ? I am not sure to understand the usefullness of this annotation.

[RouxAntoine]

Hi @fhussonnois, sorry but I read again this and I don't understand what you mean by:

I think you can just drop the @ConstructorProperties from the class as well as the constructor.

Both SpecificStateChange constructor are use somewhere else in jikkou so I can't remove it.

[fhussonnois]

Yes, sorry I was looking at the DefaultChangeResult class for which I think the serialization/deserialization should be OK without :

    @ConstructorProperties({
            "end",
            "errors",
            "status",
            "data",
            "description"
    })
    public DefaultChangeResult {
    }

Now, Jackson has a good support for records.

But, you're totally right! For the SpecificStateChange dropping the @ConstructorProperties on the constructor with the fewest args is enough.

[RouxAntoine]

Change are due to the change order of constructor.