web: fix mfa fallback string #7123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecodrr
requested changes
Dec 20, 2024
* also add selected style to mfa type selector button Signed-off-by: 01zulfi <[email protected]>
01zulfi
force-pushed
the
fix/mfa-text
branch
from
0cba454 to
a2fda2d
Compare
01zulfi
commented
Dec 20, 2024
Comment on lines
+1679
to
+1680
| fallback: "app" | "sms" | "email", | ||
| primary: "app" | "sms" | "email" |
There was a problem hiding this comment.
I've hardcoded the types here to appease TypeScript. I'm wondering if this is fine or should we import the AuthenticatorType type from the core package?
thecodrr
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7105