Test case change for updateOnly property #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
suggested changes
Aug 14, 2017
test.e2e/spec/services.spec.js
Outdated
| @@ -1102,7 +1102,7 @@ define(['angular', 'given', 'util'], function(angular, given, util) { | |||
| // Type "number" was normalized to "Number" | |||
| price: { type: 'Number' }, | |||
| // auto-injected id property | |||
| id: { id: 1, generated: true, type: 'Number' }, | |||
| id: { id: 1, generated: true, type: 'Number', updateOnly: true }, | |||
There was a problem hiding this comment.
I have mixed feelings about this change. Sure, it will fix the problem once all packages affected by updateOnly are published to npmjs, but until that happens, people may start seeing build failures.
I am proposing to rework this test and make it more resilient against possible changes in model definitions. I am thinking about a small change - replace eql operator with something like .contains or .have.properties (I never remember what is the right chai method to use). With this change in place, the test should be passing against both the currently-release loopback/juggler version and the upcoming one.
Thoughts?
There was a problem hiding this comment.
@bajtos yes.. I agree.
rashmihunt
force-pushed
the
updateonly_feature
branch
from
0ee85b2 to
1cacea0
Compare
|
@bajtos PTAL
|
bajtos
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bajtos PTAL This test case change is due to addition of updateProperty through PR loopbackio/loopback-datasource-juggler#1453 - fixes the CI for this juggler PR.