Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix mapbox event binding #232

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

titouanmathis
Copy link
Collaborator

@titouanmathis titouanmathis commented Jan 8, 2025

πŸ”— Linked issue

#231

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

By defining all emitted events, they are not accessible anymore from the useAttrs() function, preventing the components to bind events to the Mapbox objects and breaking the StoreLocator component.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.
  • I have updated the changelog.

Copy link

netlify bot commented Jan 8, 2025

βœ… Deploy Preview for vue-mapbox-gl-demo ready!

Name Link
πŸ”¨ Latest commit 4027c97
πŸ” Latest deploy log https://app.netlify.com/sites/vue-mapbox-gl-demo/deploys/677eacf62cdd340008ac3394
😎 Deploy Preview https://deploy-preview-232--vue-mapbox-gl-demo.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 8, 2025

Export Size

@studiometa/vue-mapbox-gl

Name Size Diff
MapboxPopup 1.25 kB -2 B (-0.16%) πŸ”½
StoreLocator 5.41 kB -38 B (-0.70%) πŸ”½
MapboxMap 2.04 kB -16 B (-0.78%) πŸ”½
MapboxGeocoder 1.55 kB -13 B (-0.83%) πŸ”½
MapboxImages 880 B -8 B (-0.90%) πŸ”½
MapboxGeolocateControl 1.33 kB -15 B (-1.12%) πŸ”½
MapboxLayer 962 B -11 B (-1.13%) πŸ”½
MapboxImage 656 B -9 B (-1.35%) πŸ”½
MapboxMarker 1.64 kB -29 B (-1.74%) πŸ”½
MapboxCluster 1.76 kB -39 B (-2.17%) πŸ”½
Unchanged

@studiometa/vue-mapbox-gl

Name Size Diff
MapboxFullscreenControl 1.15 kB -
MapboxNavigationControl 1.2 kB -
MapboxSource 437 B -
useControl 1.02 kB -
useEventsBinding 551 B -
useMap 166 B -
usePropsBinding 439 B -
VueScroller 634 B -

By defining all emitted events, they are not accessible anymore from the
useAttrs() function, preventing the components to bind events to the
Mapbox objects.

Fix: #231
@titouanmathis titouanmathis force-pushed the bugfix/mapbox-event-binding branch from ff105e4 to 380c4c1 Compare January 8, 2025 16:49
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 86.85%. Comparing base (3636a50) to head (4027c97).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #232   +/-   ##
========================================
  Coverage    86.85%   86.85%           
========================================
  Files           22       22           
  Lines         1453     1453           
  Branches        11       11           
========================================
  Hits          1262     1262           
  Misses         191      191           
Flag Coverage Ξ”
unittests 86.85% <100.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant